Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PDB specifications for SeldonDeployments #2508

Closed
groszewn opened this issue Sep 30, 2020 · 4 comments · Fixed by #2515
Closed

Support PDB specifications for SeldonDeployments #2508

groszewn opened this issue Sep 30, 2020 · 4 comments · Fixed by #2515
Assignees
@groszewn
Milestone
1.4

Comments

@groszewn
Copy link
Contributor

The SeldonDeployment resource exposes both the number of replicas and the ability to define autoscaling via an HPA. It would be nice to also have a way to specify PDBs as a way to limit the number of tolerable disruptions to a running deployment.
@groszewn groszewn added the triage Needs to be triaged and prioritised accordingly label Sep 30, 2020
@ukclivecox
Copy link
Contributor

Would you suggest this would be an addition to the CRD for each componentSpec alongside the HPA spec?

@groszewn
Copy link
Contributor Author

groszewn commented Oct 1, 2020

I think that would be the best approach, seems like the HPA spec lays out a nice integration that the PDB addition could follow almost exactly.

@ukclivecox
Copy link
Contributor

Would you be willing to look at a PR for this?

@groszewn
Copy link
Contributor Author

groszewn commented Oct 1, 2020

For sure, I'll report back when I have something.

groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 1, 2020
@groszewn
feat(pdb): Add support for managing PDBs
d05f035 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 1, 2020
@groszewn
feat(pdb): Add support for managing PDBs
a150105 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 1, 2020
@groszewn
feat(pdb): Add support for managing PDBs
c37010b 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 2, 2020
@groszewn
feat(pdb): Add support for managing PDBs
0dd9d89 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 2, 2020
@groszewn
feat(pdb): Add support for managing PDBs
6b07fb3 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 2, 2020
@groszewn
feat(pdb): Add support for managing PDBs
bfd2772 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 2, 2020
@groszewn
feat(pdb): Add support for managing PDBs
1d908e5 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 2, 2020
@groszewn
feat(pdb): Add support for managing PDBs
9318d68 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
@groszewn groszewn mentioned this issue Oct 2, 2020
Merged
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 2, 2020
@groszewn
feat(pdb): Add support for managing PDBs
df82a53 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 4, 2020
@groszewn
feat(pdb): Add support for managing PDBs
4ff9a07 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 7, 2020
@groszewn
feat(pdb): Add support for managing PDBs
4e0e444 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 7, 2020
@groszewn
feat(pdb): Add support for managing PDBs
2fd4118 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Oct 8, 2020
@ukclivecox ukclivecox added this to the 1.4 milestone Oct 8, 2020
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 8, 2020
@groszewn
feat(pdb): Add support for managing PDBs
e6b98c7 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 14, 2020
@groszewn
feat(pdb): Add support for managing PDBs
7814d94 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
groszewn added a commit to groszewn/seldon-core that referenced this issue Oct 15, 2020
@groszewn
feat(pdb): Add support for managing PDBs
6fe3a96 
Add support for managing PDBs through the SeldonSpec.

Contributes to SeldonIO#2508

Signed-off-by: Nick Groszewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groszewn groszewn

Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

feat(pdb): Add support for managing PDBs groszewn/seldon-core
2 participants
@ukclivecox @groszewn