Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback method is not handled in the engine's REST API #1825

Closed
ejianu opened this issue May 13, 2020 · 1 comment · Fixed by #1833
Closed

Feedback method is not handled in the engine's REST API #1825

ejianu opened this issue May 13, 2020 · 1 comment · Fixed by #1833
Assignees
Milestone

Comments

@ejianu
Copy link

ejianu commented May 13, 2020

Normally, the /api/v1.0/feedback (or /api/v0.1/feedback) should be handled so that we can make requests through the Seldon engine - as advertised in the documentation here via the external API.

We are able to use /predictions and /send-feedback (for calling the microservice API), both working as expected.

However, in the current server.go implementation there is no specification regarding feedback, resulting in 404 errors in our environment when trying to use the external API.

Please add or guide us if we are misusing the API :)
thank you

@ejianu ejianu added bug triage Needs to be triaged and prioritised accordingly labels May 13, 2020
@ukclivecox
Copy link
Contributor

Yes, this is missing from the go executor REST and should be added. It is available presently in gRPC.

@ukclivecox ukclivecox self-assigned this May 13, 2020
@ukclivecox ukclivecox added priority/p1 and removed triage Needs to be triaged and prioritised accordingly labels May 13, 2020
@ukclivecox ukclivecox added this to the 1.2 milestone May 13, 2020
qrtt1 added a commit to InfuseAI/primehub-controller that referenced this issue Mar 18, 2021
Reference:

Feedback method is not handled in the engine's REST API #1825
SeldonIO/seldon-core#1825

Signed-off-by: Ching Yi, Chan <[email protected]>
qrtt1 added a commit to InfuseAI/primehub that referenced this issue Mar 18, 2021
Reference:

Feedback method is not handled in the engine's REST API #1825
SeldonIO/seldon-core#1825

Signed-off-by: Ching Yi, Chan <[email protected]>
qrtt1 added a commit to InfuseAI/primehub-controller that referenced this issue Mar 18, 2021
Reference:

Feedback method is not handled in the engine's REST API #1825
SeldonIO/seldon-core#1825

Signed-off-by: Ching Yi, Chan <[email protected]>
qrtt1 added a commit to InfuseAI/primehub that referenced this issue Mar 18, 2021
Reference:

Feedback method is not handled in the engine's REST API #1825
SeldonIO/seldon-core#1825

Signed-off-by: Ching Yi, Chan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants