Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging that custom_tags or custom_metrics is not implemented on every request #1565

Closed
taavi-primer opened this issue Mar 19, 2020 · 3 comments
Assignees
Milestone

Comments

@taavi-primer
Copy link
Contributor

Currently the SeldonDeployments log on every request that custom_tags and custom_metrics are not implemented. This could be logged once on application start instead. Or at the very least moved to debug level.

2020-03-19 18:42:06,851 - seldon_core.user_model:client_custom_tags:131 - INFO:  custom_tags is not implemented
2020-03-19 18:43:10,423 - seldon_core.user_model:client_custom_metrics:304 - INFO:  custom_metrics is not implemented
@RafalSkolasinski RafalSkolasinski self-assigned this Mar 19, 2020
@RafalSkolasinski RafalSkolasinski added this to the 1.1 milestone Mar 19, 2020
@ChristophRose
Copy link
Contributor

ChristophRose commented Apr 20, 2020

Even though this is closed, just a small note. To suppress this currently, add the following two functions to the model class:

def tags(self):
    return {}

def metrics(self):
    return []

@ukclivecox
Copy link
Contributor

Thanks @ChristophRose If you think a small update to docs would help feel free to add a small PR.

@RafalSkolasinski
Copy link
Contributor

I think such a note should specify for which wrapper version this is still relevant - latest s2i wrapper should properly have those logs at the debug level.

ChristophRose added a commit to ChristophRose/seldon-core that referenced this issue Apr 21, 2020
ChristophRose added a commit to ChristophRose/seldon-core that referenced this issue Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants