Skip to content

Commit

Permalink
Always wait a couple seconds to sync with Jaeger
Browse files Browse the repository at this point in the history
  • Loading branch information
Adrian Gonzalez-Martin committed Feb 25, 2020
1 parent 9df5b49 commit e71614c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion testing/scripts/jaeger_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def _is_empty(result):

@retry(
stop=stop_after_attempt(5),
wait=wait_exponential(min=1, max=5),
wait=wait_exponential(max=5),
retry=retry_if_result(_is_empty),
)
def get_traces(pod_name, service, operation):
Expand Down
4 changes: 4 additions & 0 deletions testing/scripts/test_tracing.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import time
from seldon_e2e_utils import (
get_pod_names,
get_deployment_names,
Expand Down Expand Up @@ -41,6 +42,9 @@ def test_tracing_rest(namespace):
pod_names = get_pod_names(deployment_name, namespace)
pod_name = pod_names[0]

# Jaeger takes a bit of time to process all spans
time.sleep(2)

# Get traces and assert their content
traces = get_traces(pod_name, "executor", "predictions")
assert len(traces) == 1
Expand Down

0 comments on commit e71614c

Please sign in to comment.