Merge pull request #788 from ryandawsonuk/783-imagenameforprepack

having image means hashed deployment name
SeldonIO · Aug 12, 2019 · 3fc7904 · 3fc7904
2 parents 4726648 + 10d7376
commit 3fc7904
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/notebooks/server_examples.ipynb b/notebooks/server_examples.ipynb
@@ -723,19 +723,20 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 5,
+   "execution_count": 16,
    "metadata": {},
    "outputs": [
     {
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "deployment \"wines-default-057e362\" successfully rolled out\r\n"
+      "Waiting for deployment \"mnist-default-808f52c\" rollout to finish: 0 of 1 updated replicas are available...\n",
+      "deployment \"mnist-default-808f52c\" successfully rolled out\n"
      ]
     }
    ],
    "source": [
-    "!kubectl rollout status deploy/mnist-default-d53c803"
+    "!kubectl rollout status deploy/mnist-default-808f52c"
    ]
   },
   {

diff --git a/testing/scripts/test_prepackaged_servers.py b/testing/scripts/test_prepackaged_servers.py
@@ -32,7 +32,7 @@ class TestPrepackSkLearn(object):
     def test_sklearn(self):
         run("kubectl delete sdep --all", shell=True)
         run("kubectl apply -f ../../servers/sklearnserver/samples/iris.yaml", shell=True, check=True)
-        wait_for_rollout("iris-default")
+        wait_for_rollout("iris-default-8bb3ef6")
         wait_for_status("sklearn")
         print("Initial request")
         sc = SeldonClient(deployment_name="sklearn",namespace="seldon")
@@ -45,7 +45,7 @@ def test_sklearn(self):
     def test_tfserving(self):
         run("kubectl delete sdep --all", shell=True)
         run("kubectl apply -f ../../servers/tfserving/samples/mnist_rest.yaml", shell=True, check=True)
-        wait_for_rollout("mnist-default")
+        wait_for_rollout("mnist-default-808f52c")
         wait_for_status("tfserving")
         print("Initial request")
         sc = SeldonClient(deployment_name="tfserving",namespace="seldon")
@@ -58,7 +58,7 @@ def test_tfserving(self):
     def test_xgboost(self):
         run("kubectl delete sdep --all", shell=True)
         run("kubectl apply -f ../../servers/xgboostserver/samples/iris.yaml", shell=True, check=True)
-        wait_for_rollout("iris-default")
+        wait_for_rollout("iris-default-5299e79")
         wait_for_status("xgboost")
         print("Initial request")
         sc = SeldonClient(deployment_name="xgboost",namespace="seldon")