Merge pull request #338 from cliveseldon/minikube_version_comments

Update S2I version in examples
SeldonIO · Dec 12, 2018 · 340b6aa · 340b6aa
2 parents bbc0421 + 8f30dfa
commit 340b6aa
Show file tree

Hide file tree

Showing 18 changed files with 204 additions and 113 deletions.
diff --git a/components/outlier-detection/isolation-forest/isolation_forest.ipynb b/components/outlier-detection/isolation-forest/isolation_forest.ipynb
@@ -26,8 +26,8 @@
    "metadata": {},
    "source": [
     "- [helm](https://github.com/helm/helm)\n",
-    "- [minikube](https://github.com/kubernetes/minikube) --> install 0.25.2\n",
-    "- [s2i](https://github.com/openshift/source-to-image)\n",
+    "- [minikube](https://github.com/kubernetes/minikube) \n",
+    "- [s2i](https://github.com/openshift/source-to-image) >= 1.1.13 \n",
     "\n",
     "python packages:\n",
     "- scikit-learn: pip install scikit-learn --> 0.20.1"
@@ -952,7 +952,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.6.6"
+   "version": "3.6.4"
   }
  },
  "nbformat": 4,

diff --git a/components/outlier-detection/vae/outlier_vae.ipynb b/components/outlier-detection/vae/outlier_vae.ipynb
@@ -26,8 +26,8 @@
    "metadata": {},
    "source": [
     "- [helm](https://github.com/helm/helm)\n",
-    "- [minikube](https://github.com/kubernetes/minikube) --> install 0.25.2\n",
-    "- [s2i](https://github.com/openshift/source-to-image)\n",
+    "- [minikube](https://github.com/kubernetes/minikube)\n",
+    "- [s2i](https://github.com/openshift/source-to-image) >= 1.1.13\n",
     "\n",
     "python packages:\n",
     "- keras: pip install keras\n",
@@ -1094,7 +1094,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.6.6"
+   "version": "3.6.4"
   }
  },
  "nbformat": 4,

diff --git a/examples/models/deep_mnist/deep_mnist.ipynb b/examples/models/deep_mnist/deep_mnist.ipynb
@@ -135,7 +135,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/h2o_mojo/h2o_model.ipynb b/examples/models/h2o_mojo/h2o_model.ipynb
@@ -129,7 +129,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/keras_mnist/keras_mnist.ipynb b/examples/models/keras_mnist/keras_mnist.ipynb
@@ -303,7 +303,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/.../models/mean_classifier_with_custom_endpoints/mean_classifier_with_custom_endpoints.ipynb b/.../models/mean_classifier_with_custom_endpoints/mean_classifier_with_custom_endpoints.ipynb
@@ -208,7 +208,9 @@
    "cell_type": "markdown",
    "metadata": {},
    "source": [
-    "## Test in Minikube"
+    "# Test using Minikube\n",
+    "\n",
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {
@@ -219,13 +221,7 @@
    },
    "outputs": [],
    "source": [
-    "#\n",
-    "# Start minikube\n",
-    "#\n",
-    "# NOTE this example was tested using minikube v0.25.2 version.\n",
-    "# There was an issue with later minikube versions that caused\n",
-    "# the s2i build to hang.\n",
-    "#\n",
+    "\n",
     "!minikube start --memory=8096 --feature-gates=CustomResourceValidation=true --extra-config=apiserver.Authorization.Mode=RBAC"
    ]
   },
@@ -392,21 +388,21 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "Python 2",
+   "display_name": "Python 3",
    "language": "python",
-   "name": "python2"
+   "name": "python3"
   },
   "language_info": {
    "codemirror_mode": {
     "name": "ipython",
-    "version": 2
+    "version": 3
    },
    "file_extension": ".py",
    "mimetype": "text/x-python",
    "name": "python",
    "nbconvert_exporter": "python",
-   "pygments_lexer": "ipython2",
-   "version": "2.7.13"
+   "pygments_lexer": "ipython3",
+   "version": "3.6.4"
   }
  },
  "nbformat": 4,

diff --git a/examples/models/nodejs_mnist/nodejs_mnist.ipynb b/examples/models/nodejs_mnist/nodejs_mnist.ipynb
@@ -162,7 +162,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/nodejs_tensorflow/nodejs_tensorflow.ipynb b/examples/models/nodejs_tensorflow/nodejs_tensorflow.ipynb
@@ -162,7 +162,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/onnx_resnet50/onnx_resnet50.ipynb b/examples/models/onnx_resnet50/onnx_resnet50.ipynb
@@ -163,7 +163,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/r_iris/r_iris.ipynb b/examples/models/r_iris/r_iris.ipynb
@@ -100,7 +100,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/r_mnist/r_mnist.ipynb b/examples/models/r_mnist/r_mnist.ipynb
@@ -100,7 +100,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/sk_mnist/skmnist.ipynb b/examples/models/sk_mnist/skmnist.ipynb
@@ -135,7 +135,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/sklearn_iris/sklearn_iris.ipynb b/examples/models/sklearn_iris/sklearn_iris.ipynb
@@ -196,7 +196,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/template_model_bindata/modelWithBindata.ipynb b/examples/models/template_model_bindata/modelWithBindata.ipynb
@@ -273,7 +273,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {
@@ -773,7 +773,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.6.6"
+   "version": "3.6.4"
   }
  },
  "nbformat": 4,

diff --git a/examples/models/template_model_with_feedback/modelWithFeedback.ipynb b/examples/models/template_model_with_feedback/modelWithFeedback.ipynb
@@ -166,7 +166,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/examples/models/template_model_with_metrics/modelWithMetrics.ipynb b/examples/models/template_model_with_metrics/modelWithMetrics.ipynb
@@ -157,7 +157,7 @@
    "source": [
     "# Test using Minikube\n",
     "\n",
-    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need Minikube version 0.25.2**"
+    "**Due to a [minikube/s2i issue](https://github.com/SeldonIO/seldon-core/issues/253) you will need [s2i >= 1.1.13](https://github.com/openshift/source-to-image/releases/tag/v1.1.13)**"
    ]
   },
   {

diff --git a/notebooks/resources/model_short_timeouts.json b/notebooks/resources/model_short_timeouts.json
@@ -22,7 +22,7 @@
                     "spec": {
                         "containers": [
                             {
-                                "image": "seldonio/mock_classifier_rest:1.0",
+                                "image": "seldonio/mock_classifier:1.0",
                                 "imagePullPolicy": "IfNotPresent",
                                 "name": "classifier",
                                 "resources": {