Merge branch 'master' into azure-dep-optional

SeldonIO · Jul 21, 2020 · 28d2e5b · 28d2e5b
2 parents 0095ba5 + 405c8d0
commit 28d2e5b
Show file tree

Hide file tree

Showing 33 changed files with 168 additions and 211 deletions.
diff --git a/ci/add-pr-build-comment b/ci/add-pr-build-comment
@@ -18,12 +18,11 @@ BUILD_NUMBER=${BUILD_NUMBER}
 PIPELINE_CONTEXT=${PIPELINE_CONTEXT}
 
 COMMENT_MSG=$(cat <<EOF
-## STARTING TEST [ ${PIPELINE_CONTEXT} # ${BUILD_NUMBER} ]
-
-Logs will be available when test completes in the following link:
+$(date)
+The logs for [${PIPELINE_CONTEXT}] [${BUILD_NUMBER}] will show after the pipeline context has finished.  
 https://github.com/${REPO_OWNER}/${REPO_NAME}/blob/gh-pages/jenkins-x/logs/${REPO_OWNER}/${REPO_NAME}/PR-${PULL_NUMBER}/${BUILD_NUMBER}.log
 
-Impatient try:
+impatient try  
 jx get build logs ${REPO_OWNER}/${REPO_NAME}/PR-${PULL_NUMBER} --build=${BUILD_NUMBER}
 EOF
 )

diff --git a/ci/add-pr-build-comment-success b/ci/add-pr-build-comment-success
diff --git a/core-builder/.gitignore b/core-builder/.gitignore
@@ -1,3 +1 @@
 dev_requirements.txt
-requirements.txt
-requirements-dev.txt
diff --git a/core-builder/Dockerfile b/core-builder/Dockerfile
@@ -64,13 +64,12 @@ RUN apt-get upgrade && \
         apt-get install zlib1g-dev -y && \
         apt-get install libssl-dev -y && \
 	apt-get install libbz2-dev -y && \
-	apt-get install libsqlite3-dev && \
 	apt-get install liblzma-dev -y
 
 RUN curl -SLO https://www.python.org/ftp/python/${PYTHON_VERSION}/Python-${PYTHON_VERSION}.tgz \
     && tar xvf Python-${PYTHON_VERSION}.tgz \
     && cd Python-${PYTHON_VERSION} \
-    && ./configure --prefix=/usr/local --with-openssl --enable-loadable-sqlite-extensions \
+    && ./configure --prefix=/usr/local --with-openssl \
     && make \
     && make altinstall \
     && cd / \
@@ -89,31 +88,12 @@ RUN pip install --upgrade setuptools
 RUN pip install pyyaml
 RUN pip install grpcio
 RUN pip install grpcio-tools
-RUN pip install flatbuffers
-RUN pip install twine
-RUN pip install mypy-protobuf
-RUN pip install pysqlite3
-RUN pip install db-sqlite3
-
-# Install flatc
-RUN apt-get install cmake -y
-RUN INSTALL_DIR=/tmp/flatc-install && \
-    mkdir $INSTALL_DIR && \
-    cd $INSTALL_DIR && \
-    git clone https://github.com/google/flatbuffers.git && \
-    cd flatbuffers && \
-    cmake -G "Unix Makefiles" && \
-    make && \
-    cp ./flatc /usr/local/bin/ && \
-    rm -rf $INSTALL_DIR
-
 RUN apt-get remove -y --auto-remove && apt-get clean -y && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
 
 # INSTALL GO
-ENV GO_VERSION=1.14.6
 ENV PATH /usr/local/go/bin:$PATH
-RUN wget "https://dl.google.com/go/go$GO_VERSION.linux-amd64.tar.gz" && \
-        tar -zxvf "go$GO_VERSION.linux-amd64.tar.gz" && \
+RUN wget https://dl.google.com/go/go1.13.8.linux-amd64.tar.gz && \
+        tar -zxvf go1.13.8.linux-amd64.tar.gz && \
         mv go/ /usr/local/go
 RUN curl -sL https://go.kubebuilder.io/dl/2.3.0/linux/amd64 | tar -xz -C /tmp/ && \
         mv /tmp/kubebuilder_2.3.0_linux_amd64 /usr/local/kubebuilder/
@@ -135,29 +115,18 @@ RUN \
 # install jupyter
 RUN pip install jupyter
 
-# Ginkgo
-RUN go get github.com/onsi/ginkgo/ginkgo
-
 # Install grpcurl
-RUN wget https://github.com/fullstorydev/grpcurl/releases/download/v1.6.1/grpcurl_1.6.1_linux_x86_64.tar.gz && \
-        tar -zxvf grpcurl_1.6.1_linux_x86_64.tar.gz && \
-        chmod +x grpcurl && \
-        mv grpcurl /usr/local/bin/grpcurl
+RUN go get github.com/fullstorydev/grpcurl && \
+    go install github.com/fullstorydev/grpcurl/cmd/grpcurl
 
 ENV PATH="${PATH}:/root/go/bin"
 
 # Notebooks python requirements
-COPY dev_requirements.txt /tmp/dev_requirements.txt
-RUN pip install -r /tmp/dev_requirements.txt
-# General python requirements
-COPY requirements.txt /tmp/requirements.txt
-COPY requirements-dev.txt /tmp/requirements-dev.txt
-RUN cd /tmp && pip install -r requirements-dev.txt
-
-# Install Jenkins X CLI
-RUN curl -L "https://github.com/jenkins-x/jx/releases/download/v2.1.95/jx-darwin-amd64.tar.gz" | tar xzv "jx" && \
-        chmod +x ./jx && \
-        mv ./jx /usr/bin/jx
+COPY dev_requirements.txt /tmp/requirements.txt
+RUN pip install -r /tmp/requirements.txt
+
+# Ginkgo
+RUN go get -u github.com/onsi/ginkgo/ginkgo
 
 WORKDIR /work
 

diff --git a/core-builder/Makefile b/core-builder/Makefile
@@ -1,9 +1,7 @@
 DOCKER_IMAGE_NAME=seldonio/core-builder
-DOCKER_IMAGE_VERSION=0.16
+DOCKER_IMAGE_VERSION=0.15
 
 build_docker_image:
-	cp ../python/requirements.txt .
-	cp ../python/requirements-dev.txt .
 	cp ../testing/scripts/dev_requirements.txt .
 	docker build --force-rm=true -t $(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION) .
 push_to_registry:

diff --git a/doc/source/analytics/routers.md b/doc/source/analytics/routers.md
@@ -16,3 +16,7 @@ As an example, consider writing a custom A/B/C... testing component with a user-
 Because routers are generic components that only need to implement the ```Route``` method, there is considerable flexibility in designing the routing logic. Some example concepts going beyond random testing and multi-armed bandits:
 * Routing depending on external conditions, e.g. use the time of day to route traffic to a model that has been known to perform best during a particular time period.
 * Model as a router: use a predictive model within a router component to first determine a higher level class membership (e.g. cat vs dog) and according to the decision route traffic to more specific models (e.g. dog-specific model to infer a breed).
+
+## Limitations
+
+The current default orchestrator in Go the "executor" does not return routing meta data in request calls. This is a [known issue](https://github.com/SeldonIO/seldon-core/issues/1823). 
diff --git a/doc/source/graph/svcorch.md b/doc/source/graph/svcorch.md
@@ -129,7 +129,7 @@ You can set custom resource request and limits for this component by specifying
 
 ```
 
-## Bypass Service Orchestrator (version >= 0.5.0, alpha feature)
+## Bypass Service Orchestrator (version >= 0.5.0)
 
 If you are deploying a single model then for those wishing to minimize the latency and resource usage for their deployed model you can opt out of having the service orchestrator included. To do this add the annotation `seldon.io/no-engine: "true"` to the predictor. The predictor must contain just a single node graph. An example is shown below:
 
@@ -163,3 +163,7 @@ spec:
 In these cases the external API requests will be sent directly to your model. At present only the python wrapper (>=0.13-SNAPSHOT) has been modified to allow this.
 
 Note no metrics or extra data will be added to the request so this would need to be done by your model itself if needed.
+
+## Routing in Metadata
+
+The current default orchestrator in Go the "executor" does not return routing meta data in request calls. This is a [known issue](https://github.com/SeldonIO/seldon-core/issues/1823). 
diff --git a/doc/source/reference/images.md b/doc/source/reference/images.md
@@ -5,29 +5,29 @@
 
 | Description | Image URL | Stable Version | Development |
 |-------------|-----------|----------------|-------------|
-| [Seldon Operator](../workflow/install.md) | [seldonio/seldon-core-operator](https://hub.docker.com/r/seldonio/seldon-core-operator/tags/) | 1.2.1 | 1.2.2-rc |
-| [Seldon Service Orchestrator (Go)](../graph/svcorch.md)| [seldonio/seldon-core-executor](https://hub.docker.com/r/seldonio/executor/tags/) | 1.2.1 | 1.2.2-rc |
-| [Seldon Service Orchestrator (Java)](../graph/svcorch.html#using-the-java-engine) | [seldonio/engine](https://hub.docker.com/r/seldonio/engine/tags/) | 1.2.1 | 1.2.2-rc |
+| [Seldon Operator](../workflow/install.md) | [seldonio/seldon-core-operator](https://hub.docker.com/r/seldonio/seldon-core-operator/tags/) | 1.2.2 | 1.2.3-dev |
+| [Seldon Service Orchestrator (Go)](../graph/svcorch.md)| [seldonio/seldon-core-executor](https://hub.docker.com/r/seldonio/executor/tags/) | 1.2.2 | 1.2.3-dev |
+| [Seldon Service Orchestrator (Java)](../graph/svcorch.html#using-the-java-engine) | [seldonio/engine](https://hub.docker.com/r/seldonio/engine/tags/) | 1.2.2 | 1.2.3-dev |
 
 ## Pre-packaged servers
 
 
 | Description | Image URL | Version | 
 |-------------|-----------|---------|
-| [MLFlow Server REST](../servers/mlflow.md) | [seldonio/mlflowserver_rest](https://hub.docker.com/r/seldonio/mlflowserver_rest/tags/) | 1.2.1 | 
-| [MLFlow Server GRPC](../servers/mlflow.md) | [seldonio/mlflowserver_grpc](https://hub.docker.com/r/seldonio/mlflowserver_grpc/tags/) | 1.2.1 | 
-| [SKLearn Server REST](../servers/sklearn.md) | [seldonio/sklearnserver_rest](https://hub.docker.com/r/seldonio/sklearnserver_rest/tags/) | 1.2.1 | 
-| [SKLearn Server GRPC](../servers/sklearn.md) | [seldonio/sklearnserver_grpc](https://hub.docker.com/r/seldonio/sklearnserver_grpc/tags/) | 1.2.1 | 
-| [XGBoost Server REST](../servers/xgboost.md) | [seldonio/xgboostserver_rest](https://hub.docker.com/r/seldonio/xgboostserver_rest/tags/) | 1.2.1 | 
-| [XGBoost Server GRPC](../servers/xgboost.md) | [seldonio/xgboostserver_grpc](https://hub.docker.com/r/seldonio/xgboostserver_grpc/tags/) | 1.2.1 | 
+| [MLFlow Server REST](../servers/mlflow.md) | [seldonio/mlflowserver_rest](https://hub.docker.com/r/seldonio/mlflowserver_rest/tags/) | 1.2.2 | 
+| [MLFlow Server GRPC](../servers/mlflow.md) | [seldonio/mlflowserver_grpc](https://hub.docker.com/r/seldonio/mlflowserver_grpc/tags/) | 1.2.2 | 
+| [SKLearn Server REST](../servers/sklearn.md) | [seldonio/sklearnserver_rest](https://hub.docker.com/r/seldonio/sklearnserver_rest/tags/) | 1.2.2 | 
+| [SKLearn Server GRPC](../servers/sklearn.md) | [seldonio/sklearnserver_grpc](https://hub.docker.com/r/seldonio/sklearnserver_grpc/tags/) | 1.2.2 | 
+| [XGBoost Server REST](../servers/xgboost.md) | [seldonio/xgboostserver_rest](https://hub.docker.com/r/seldonio/xgboostserver_rest/tags/) | 1.2.2 | 
+| [XGBoost Server GRPC](../servers/xgboost.md) | [seldonio/xgboostserver_grpc](https://hub.docker.com/r/seldonio/xgboostserver_grpc/tags/) | 1.2.2 | 
 
 ## Language wrappers
 
 | Description | Image URL | Stable Version | Development |
 |-------------|-----------|----------------|-------------|
-| [Seldon Python 3 (3.6) Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python3](https://hub.docker.com/r/seldonio/seldon-core-s2i-python3/tags/) | 1.2.1 | 1.2.2-rc |
-| [Seldon Python 3.6 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python36](https://hub.docker.com/r/seldonio/seldon-core-s2i-python36/tags/) | 1.2.1 | 1.2.2-rc |
-| [Seldon Python 3.7 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python37](https://hub.docker.com/r/seldonio/seldon-core-s2i-python37/tags/) | 1.2.1 | 1.2.2-rc |
+| [Seldon Python 3 (3.6) Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python3](https://hub.docker.com/r/seldonio/seldon-core-s2i-python3/tags/) | 1.2.2 | 1.2.3-dev |
+| [Seldon Python 3.6 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python36](https://hub.docker.com/r/seldonio/seldon-core-s2i-python36/tags/) | 1.2.2 | 1.2.3-dev |
+| [Seldon Python 3.7 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python37](https://hub.docker.com/r/seldonio/seldon-core-s2i-python37/tags/) | 1.2.2 | 1.2.3-dev |
 
 ## Server proxies
 
@@ -43,7 +43,7 @@
 
 | Description | Python Version | Version |
 |-------------|----------------|---------|
-| [seldon-core](https://pypi.org/project/seldon-core/) | >3.4,<3.7 | 1.2.1 |
+| [seldon-core](https://pypi.org/project/seldon-core/) | >3.4,<3.7 | 1.2.2 |
 | [seldon-core](https://pypi.org/project/seldon-core/) | 2,>=3,<3.7 | 0.2.6 (deprecated) |
 
 

diff --git a/engine/pom.xml b/engine/pom.xml
@@ -305,7 +305,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
-      <version>3.10</version>
+      <version>3.11</version>
     </dependency>
     <dependency>
       <groupId>org.springframework.boot</groupId>

diff --git a/executor/api/rest/server.go b/executor/api/rest/server.go
@@ -22,6 +22,7 @@ import (
 	"github.com/seldonio/seldon-core/executor/predictor"
 	v1 "github.com/seldonio/seldon-core/operator/apis/machinelearning.seldon.io/v1"
 	logf "sigs.k8s.io/controller-runtime/pkg/runtime/log"
+	"time"
 )
 
 type SeldonRestApi struct {
@@ -67,8 +68,9 @@ func (r *SeldonRestApi) CreateHttpServer(port int) *http.Server {
 	// will apply no timeout at all. Instead, we control that through the
 	// http.Client instance making requests to the underlying node graph servers.
 	return &http.Server{
-		Handler: r.Router,
-		Addr:    address,
+		Handler:     r.Router,
+		Addr:        address,
+		IdleTimeout: 65 * time.Second,
 	}
 }
 

diff --git a/executor/go.mod b/executor/go.mod
@@ -18,14 +18,14 @@ require (
 	github.com/seldonio/seldon-core/operator v0.0.0-00010101000000-000000000000
 	github.com/soheilhy/cmux v0.1.4
 	github.com/tensorflow/tensorflow/tensorflow/go/core v0.0.0-00010101000000-000000000000
-	github.com/uber/jaeger-client-go v2.24.0+incompatible
+	github.com/uber/jaeger-client-go v2.25.0+incompatible
 	github.com/uber/jaeger-lib v2.2.0+incompatible // indirect
 	go.uber.org/zap v1.15.0
 	golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
 	google.golang.org/grpc v1.30.0
 	gotest.tools v2.2.0+incompatible
-	k8s.io/api v0.17.8
-	k8s.io/apimachinery v0.17.8
+	k8s.io/api v0.17.9
+	k8s.io/apimachinery v0.17.9
 	sigs.k8s.io/controller-runtime v0.5.8
 )
 

diff --git a/executor/go.sum b/executor/go.sum
@@ -366,8 +366,8 @@ github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UV
 github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
 github.com/tidwall/pretty v1.0.0/go.mod h1:XNkn88O1ChpSDQmQeStsy+sBenx6DDtFZJxhVysOjyk=
 github.com/tmc/grpc-websocket-proxy v0.0.0-20170815181823-89b8d40f7ca8/go.mod h1:ncp9v5uamzpCO7NfCPTXjqaC+bZgJeR0sMTm6dMHP7U=
-github.com/uber/jaeger-client-go v2.24.0+incompatible h1:CGchgJcHsDd2jWnaL4XngByMrXoGHh3n8oCqAKx0uMo=
-github.com/uber/jaeger-client-go v2.24.0+incompatible/go.mod h1:WVhlPFC8FDjOFMMWRy2pZqQJSXxYSwNYOkTr/Z6d3Kk=
+github.com/uber/jaeger-client-go v2.25.0+incompatible h1:IxcNZ7WRY1Y3G4poYlx24szfsn/3LvK9QHCq9oQw8+U=
+github.com/uber/jaeger-client-go v2.25.0+incompatible/go.mod h1:WVhlPFC8FDjOFMMWRy2pZqQJSXxYSwNYOkTr/Z6d3Kk=
 github.com/uber/jaeger-lib v2.2.0+incompatible h1:MxZXOiR2JuoANZ3J6DE/U0kSFv/eJ/GfSYVCjK7dyaw=
 github.com/uber/jaeger-lib v2.2.0+incompatible/go.mod h1:ComeNDZlWwrWnDv8aPp0Ba6+uUTzImX/AauajbLI56U=
 github.com/ugorji/go/codec v0.0.0-20181204163529-d75b2dcb6bc8/go.mod h1:VFNgLljTbGfSG7qAOspJ7OScBnGdDN/yBr0sguwnwf0=
@@ -595,19 +595,26 @@ istio.io/api v0.0.0-20200513175333-ae3da0d240e3/go.mod h1:bcY3prusO/6vA6zGHz4PNG
 istio.io/client-go v0.0.0-20200513180646-f8d9d8ff84e6/go.mod h1:8K6yamLGK/uYhD60s3PKbeSo0gF+Gc15asklRx408zA=
 istio.io/gogo-genproto v0.0.0-20190930162913-45029607206a/go.mod h1:OzpAts7jljZceG4Vqi5/zXy/pOg1b209T3jb7Nv5wIs=
 k8s.io/api v0.17.0/go.mod h1:npsyOePkeP0CPwyGfXDHxvypiYMJxBWAMpQxCaJ4ZxI=
-k8s.io/api v0.17.8 h1:8JHlbqJ3A6sGhoacXfu/sASSD+HWWqVq67qt9lyB0kU=
 k8s.io/api v0.17.8/go.mod h1:N++Llhs8kCixMUoCaXXAyMMPbo8dDVnh+IQ36xZV2/0=
-k8s.io/apiextensions-apiserver v0.17.8 h1:/E4h3wlnhdanffd/WzVJYd86I0fj76+4OPoHooAyHDI=
+k8s.io/api v0.17.9 h1:BA/U8qtSNzx7BbmQy3lODbCxVMKGNUpBJ2fjsKt6OOY=
+k8s.io/api v0.17.9/go.mod h1:avJJAA1fSV6tnbCGW2K+S+ilDFW7WpNr5BScoiZ1M1U=
 k8s.io/apiextensions-apiserver v0.17.8/go.mod h1:5H/i0XiKizIE9SkoAQaU/ou31JJBIffbsT0ALA18GmE=
+k8s.io/apiextensions-apiserver v0.17.9 h1:GWtUr9LErCZBV7QEUIF7wiICPG6wzPukFRrwDv/AIdM=
+k8s.io/apiextensions-apiserver v0.17.9/go.mod h1:p2C9cDflVAUPMl5/QOMHxnSzQWF/cDqu7AP2KUXHHMA=
 k8s.io/apimachinery v0.17.0/go.mod h1:b9qmWdKlLuU9EBh+06BtLcSf/Mu89rWL33naRxs1uZg=
-k8s.io/apimachinery v0.17.8 h1:zXvd8rYMAjRJXpILP9tdAiUnFIENM9EmHuE81apIoms=
 k8s.io/apimachinery v0.17.8/go.mod h1:Lg8zZ5iC/O8UjCqW6DNhcQG2m4TdjF9kwG3891OWbbA=
+k8s.io/apimachinery v0.17.9 h1:knQxNgMu57Oxlm12J6DS375kmGMeuWV0VNzRRUBB2Yk=
+k8s.io/apimachinery v0.17.9/go.mod h1:Lg8zZ5iC/O8UjCqW6DNhcQG2m4TdjF9kwG3891OWbbA=
 k8s.io/apiserver v0.17.8/go.mod h1:XU2YBi1I/v/P1R5lb0lEwSQ1rnXE01k7yxVtdIWH4Lo=
+k8s.io/apiserver v0.17.9/go.mod h1:Qaxd3EbeoPRBHVMtFyuKNAObqP6VAkzIMyWYz8KuE2k=
 k8s.io/client-go v0.17.0/go.mod h1:TYgR6EUHs6k45hb6KWjVD6jFZvJV4gHDikv/It0xz+k=
-k8s.io/client-go v0.17.8 h1:cuZSfjqVrNjoZ3wViQHljFPyWMOcgxUjjmQs5Rifbxk=
 k8s.io/client-go v0.17.8/go.mod h1:SJsDS64AAtt9VZyeaQMb4Ck5etCitZ/FwajWdzua5eY=
+k8s.io/client-go v0.17.9 h1:qUPhohX4bUBx0L7pfye02aPnu3PQ0t+B8dqHfGvt++k=
+k8s.io/client-go v0.17.9/go.mod h1:3cM92qAd1XknA5IRkRfpJhl9OQjkYy97ZEUio70wVnI=
 k8s.io/code-generator v0.17.8/go.mod h1:iiHz51+oTx+Z9D0vB3CH3O4HDDPWrvZyUgUYaIE9h9M=
+k8s.io/code-generator v0.17.9/go.mod h1:iiHz51+oTx+Z9D0vB3CH3O4HDDPWrvZyUgUYaIE9h9M=
 k8s.io/component-base v0.17.8/go.mod h1:xfNNdTAMsYzdiAa8vXnqDhRVSEgkfza0iMt0FrZDY7s=
+k8s.io/component-base v0.17.9/go.mod h1:Wg22ePDK0mfTa+bEFgZHGwr0h40lXnYy6D7D+f7itFk=
 k8s.io/gengo v0.0.0-20190128074634-0689ccc1d7d6/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
 k8s.io/gengo v0.0.0-20190822140433-26a664648505/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
 k8s.io/klog v0.0.0-20181102134211-b9b56d5dfc92/go.mod h1:Gq+BEi5rUBO/HRz0bTSXDUcqjScdoY3a9IHpCEIOOfk=

diff --git a/jenkins-x-engine.yml b/jenkins-x-engine.yml
@@ -4,7 +4,7 @@ pipelineConfig:
     pullRequest:
       pipeline:
         agent:
-          image: seldonio/core-builder:0.16
+          image: seldonio/core-builder:0.15
         stages:
           - name: pr-build-comment
             steps:
@@ -64,9 +64,3 @@ pipelineConfig:
                     type: Directory
                 - name: dind-storage
                   emptyDir: {}
-          - name: pr-build-comment-success
-            steps:
-              - agent:
-                  image: gcr.io/jenkinsxio/builder-go:2.0.916-264
-                dir: ci
-                sh: "./add-pr-build-comment-success"
diff --git a/jenkins-x-integration.yml b/jenkins-x-integration.yml
@@ -4,7 +4,7 @@ pipelineConfig:
     pullRequest:
       pipeline:
         agent:
-          image: seldonio/core-builder:0.16
+          image: seldonio/core-builder:0.15
         stages:
           - name: pr-build-comment
             steps:
@@ -54,9 +54,3 @@ pipelineConfig:
                     type: Directory
                 - name: dind-storage
                   emptyDir: {}
-          - name: pr-build-comment-success
-            steps:
-              - agent:
-                  image: gcr.io/jenkinsxio/builder-go:2.0.916-264
-                dir: ci
-                sh: "./add-pr-build-comment-success"
diff --git a/jenkins-x-lint.yml b/jenkins-x-lint.yml
@@ -4,7 +4,7 @@ pipelineConfig:
     pullRequest:
       pipeline:
         agent:
-          image: seldonio/core-builder:0.16
+          image: seldonio/core-builder:0.15
         stages:
         - name: pr-build-comment
           steps:
@@ -15,6 +15,8 @@ pipelineConfig:
         - name: lint-checks
           parallel:
           - name: lint-python
+            agent:
+              image: seldonio/python-builder:0.2
             steps:
               - name: lint-python
                 command: make
@@ -23,22 +25,20 @@ pipelineConfig:
                 - install_dev
                 - lint 
           - name: lint-operator
+            agent:
+              image: seldonio/core-builder:0.15
             steps:
               - name: lint-operator
                 command: make
                 args:
                   - -C operator
                   - lint
           - name: lint-executor
+            agent:
+              image: seldonio/core-builder:0.15
             steps:
               - name: lint-executor
                 command: make
                 args:
                   - -C executor
                   - lint
-        - name: pr-build-comment-success
-          steps:
-          - agent:
-              image: gcr.io/jenkinsxio/builder-go:2.0.916-264
-            dir: ci
-            sh: "./add-pr-build-comment-success"