-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to mypy 0.9 #638
Update to mypy 0.9 #638
Conversation
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
- Coverage 82.06% 81.96% -0.10%
==========================================
Files 77 77
Lines 10519 10519
==========================================
- Hits 8632 8622 -10
- Misses 1887 1897 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would wager that the type-var
to arg-type
error was a bug in the older version of mypy
.
Yeh agreed, |
Update to mypy 0.900. This is a precursor to #605.
This PR is similar to SeldonIO/alibi-detect#490, but with a few extra changes:
In explainers/cfproto.py two lines that previously raised
type-var
arguments are now raisingarg-type
errors, so thetype: ignore
's have been updated to ignore these.arg-type
errors seem logical to me here, but I might be missing something.The second call to
ray.remote()
below:results in the error:
This doesn't seem surprising since the overloaded type sigs are all similar to:
i.e.
ObjectRef
's are always expected, rather thanAny
. I don't have an answer for whymypy<0.9
doesn't pick this up though... To avoid an error,type: ignore[call-overload]
is added.