Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite for #521 as the newest
tensorflow
pulls in the newestnumpy
which has support for type hints. This has revealed some typing issues in our codebase.This PR uses
type: ignore
fairly liberally as in some places it is not fully clear why the upstream types are failing (e.g.List[int]
not being valid input tonp.ix_
), and in others we're missing some validation/type narrowing on our side (e.g.baselines
). I've also usedcast
in a few places to help the typechecker narrow down types based on the boolean flags we use.