Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tensorflow to 2.12 #764

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Bump tensorflow to 2.12 #764

merged 2 commits into from
Apr 17, 2023

Conversation

ascillitoe
Copy link
Contributor

@ascillitoe ascillitoe commented Apr 5, 2023

2.12 release notes here.

Possibly important changes:

  • Python 3.11 added and 3.7 dropped. - No action needed. We are tracking upgrade to Python 3.11 in Support Python 3.11 #676, and 3.7 will be dropped when EOL
  • Moved all saving-related utilities to a new namespace, keras.saving, for example: keras.saving.load_model, keras.saving.save_model, keras.saving.custom_object_scope, keras.saving.get_custom_objects, keras.saving.register_keras_serializable,keras.saving.get_registered_name and keras.saving.get_registered_object. The previous API locations (in keras.utils and keras.models) will be available indefinitely, but we recommend you update your code to point to the new API locations. - We could change tf.keras.models.load_model used in saving._tensorflow.loading to tf.keras.saving.load_model, but would need logic to cope with older tf versions, and old api locations available indefinitely, so best to leave.
  • The new Keras model saving format (.keras) is available. You can start using it via model.save(f"{fname}.keras", save_format="keras_v3"). In the future it will become the default for all files with the .keras extension.... - We could explore moving to keras_v3 instead of SavedModel, but would not be compatible with older tf versions so probably best to leave...

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #764 (fdba5f5) into master (3bd3148) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   80.86%   80.82%   -0.05%     
==========================================
  Files         144      144              
  Lines        9648     9607      -41     
==========================================
- Hits         7802     7765      -37     
+ Misses       1846     1842       -4     
Flag Coverage Δ
ubuntu-latest-3.10 ?
ubuntu-latest-3.7 80.69% <ø> (ø)
ubuntu-latest-3.8 80.70% <ø> (?)
ubuntu-latest-3.9 80.70% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@ascillitoe
Copy link
Contributor Author

@jklaise @mauicv CI is now passing. I've put down my thoughts above on what I see as the main changes of interest. To me it looks like we are good to merge (same for alibi).

@jklaise jklaise merged commit b1cd5a7 into SeldonIO:master Apr 17, 2023
mauicv added a commit to mauicv/alibi-detect that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants