Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge patch/v0.10.5 into master #733

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Merge patch/v0.10.5 into master #733

merged 5 commits into from
Jan 26, 2023

Conversation

ascillitoe
Copy link
Contributor

@ascillitoe ascillitoe commented Jan 26, 2023

This PR merges the v0.10.5 patch into master.

The v0.10.5 patch consists of two bug fixes (#729 and #732) that prevented backward compatibility when loading detectors saved with <v0.10.0. These bugs also meant that detectors saved with save_detector(..., legacy=True) in >=v0.10.0 did not properly obey the legacy file format. The config.toml file format used by default in >=v0.10.0 is unaffected.

@ascillitoe ascillitoe requested a review from mauicv January 26, 2023 10:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #733 (ed36837) into master (1b3295f) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   80.32%   80.32%   -0.01%     
==========================================
  Files         137      137              
  Lines        9292     9300       +8     
==========================================
+ Hits         7464     7470       +6     
- Misses       1828     1830       +2     
Flag Coverage Δ
macos-latest-3.9 76.80% <92.30%> (-0.01%) ⬇️
ubuntu-latest-3.10 80.21% <92.30%> (-0.01%) ⬇️
ubuntu-latest-3.7 80.11% <92.30%> (-0.01%) ⬇️
ubuntu-latest-3.8 80.15% <92.30%> (-0.01%) ⬇️
ubuntu-latest-3.9 80.15% <92.30%> (-0.01%) ⬇️
windows-latest-3.9 76.80% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi_detect/saving/_tensorflow/loading.py 85.20% <87.50%> (-0.27%) ⬇️
alibi_detect/saving/_tensorflow/saving.py 81.87% <100.00%> (+0.05%) ⬆️
alibi_detect/saving/loading.py 93.86% <100.00%> (ø)

@ascillitoe ascillitoe merged commit c0c5e64 into SeldonIO:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants