Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx requirement from <6.0.0,>=4.2.0 to >=4.2.0,<7.0.0 #709

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 11, 2023

Updates the requirements on sphinx to permit the latest version.

Release notes

Sourced from sphinx's releases.

v6.1.3

Changelog: https://www.sphinx-doc.org/en/master/changes.html

Changelog

Sourced from sphinx's changelog.

Release 6.1.3 (released Jan 10, 2023)

Bugs fixed

  • #11116: Reverted to previous Sphinx 5 node copying method
  • #11117: Reverted changes to parallel image processing from Sphinx 6.1.0
  • #11119: Supress ValueError in the linkcheck builder

Release 6.1.2 (released Jan 07, 2023)

Bugs fixed

  • #11101: LaTeX: div.topic_padding key of sphinxsetup documented at 5.1.0 was implemented with name topic_padding

  • #11099: LaTeX: shadowrule key of sphinxsetup causes PDF build to crash since Sphinx 5.1.0

  • #11096: LaTeX: shadowsize key of sphinxsetup causes PDF build to crash since Sphinx 5.1.0

  • #11095: LaTeX: shadow of :dudir:topic and contents_ boxes not in page margin since Sphinx 5.1.0

    .. _contents: https://docutils.sourceforge.io/docs/ref/rst/directives.html#table-of-contents

  • #11100: Fix copying images when running under parallel mode.

Release 6.1.1 (released Jan 05, 2023)

Bugs fixed

  • #11091: Fix util.nodes.apply_source_workaround for literal_block nodes with no source information in the node or the node's parents.

Release 6.1.0 (released Jan 05, 2023)

Dependencies

Incompatible changes

... (truncated)

Commits
  • 776d01e Bump to 6.1.3 final
  • a2e922a CHANGES for Sphinx 6.1.3
  • 31162a9 Handle exceptions for get_node_source and get_node_line
  • dcb4429 Restore Sphinx 5 nodes.Element copying behaviour
  • 2a7c40d Undo parallel image changes
  • 7841d3d Ignore more checks in Ruff 0.0.214
  • ddbc5b5 Bump version
  • 393b408 Bump to 6.1.2 final
  • d8a5dd8 Add note to CHANGES for PR 11100
  • a1cd19e Fix copying images under parallel execution (#11100)
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 11, 2023
@dependabot dependabot bot requested review from ascillitoe, jklaise and mauicv January 11, 2023 12:07
@ascillitoe ascillitoe added the DO NOT MERGE Do not merge this PR label Jan 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #709 (697a50d) into master (1d1957b) will not change coverage.
The diff coverage is n/a.

❗ Current head 697a50d differs from pull request most recent head 6f45203. Consider uploading reports for the commit 6f45203 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files         146      146           
  Lines        9720     9720           
=======================================
  Hits         7872     7872           
  Misses       1848     1848           

@dependabot dependabot bot force-pushed the dependabot/pip/sphinx-gte-4.2.0-and-lt-7.0.0 branch from a4f4933 to ec03abb Compare January 19, 2023 11:18
@dependabot dependabot bot force-pushed the dependabot/pip/sphinx-gte-4.2.0-and-lt-7.0.0 branch from ec03abb to 08eded2 Compare February 21, 2023 13:35
@ascillitoe ascillitoe added the Blocked Issue is blocked by some bigger issue label Apr 5, 2023
@ascillitoe
Copy link
Contributor

ascillitoe commented Apr 5, 2023

This is now blocked by sphinx-design not supporting sphinx >= 6.0. sphinx-design hasn't been updated since Aug 22 2022 so should probably look at migrating away from it...

Edit: I spoke to soon. sphinx-design 0.4 is out (#769), supporting sphinx >= 6.0.

Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES)
- [Commits](sphinx-doc/sphinx@v4.2.0...v6.1.3)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/sphinx-gte-4.2.0-and-lt-7.0.0 branch from 08eded2 to 4e743f1 Compare April 5, 2023 14:50
@ascillitoe
Copy link
Contributor

@dependabot rebase

@ascillitoe
Copy link
Contributor

This is now blocked by sphinx-design not supporting sphinx >= 6.0. sphinx-design hasn't been updated since Aug 22 2022 so should probably look at migrating away from it...

Edit: I spoke to soon. sphinx-design 0.4 is out (#769), supporting sphinx >= 6.0.

Still blocked by #756 ...

@ascillitoe
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 26, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 26, 2023

A newer version of sphinx exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@ascillitoe ascillitoe removed Blocked Issue is blocked by some bigger issue DO NOT MERGE Do not merge this PR labels Apr 26, 2023
Copy link
Contributor

@ascillitoe ascillitoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sphinx v6.2.1 now being installed. Docs look OK, 3 warnings as expected.

@ascillitoe ascillitoe merged commit 2b76143 into master Apr 26, 2023
@ascillitoe ascillitoe deleted the dependabot/pip/sphinx-gte-4.2.0-and-lt-7.0.0 branch April 26, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants