Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inference params support to MLFlow's custom invocation endpoint (… #1375

Conversation

M4nouel
Copy link
Contributor

@M4nouel M4nouel commented Sep 3, 2023

  • Adds inference params support to MLFlow's custom invocation endpoint (Add inference params support to MLFlow's custom invocation endpoint #1374)
  • Fixes FutureWarning: ``mlflow.pyfunc.scoring_server.infer_and_parse_json_input`` is deprecated since 2.6.0. This method will be removed in a future release. Use ``infer_and_parse_data`` instead.
  • Adds tests of MLFlow runtime invocation method.

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @M4nouel ,

Thanks for the contribution - that's a great PR! Self-contained, properly tested, addressing some warnings... nice job! 🚀

Changes look good from my side, so once the tests are green this should be good to go 👍

@M4nouel
Copy link
Contributor Author

M4nouel commented Sep 6, 2023

Hi @adriangonz ,

Thank you !
I have a linting problem, I'll fix it and rebase my branch!

@M4nouel M4nouel force-pushed the feature/infer_params_mlflow_custom_invocation_endpoint branch from e07a6cb to 2045737 Compare September 6, 2023 15:36
@adriangonz adriangonz merged commit a7cf4ee into SeldonIO:master Sep 6, 2023
adriangonz pushed a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants