fix($rootScope): ng-repeat can't handle NaN values. angular#4605

$watchCollection checks if oldValue !== newValue which does not work for NaN Closes angular#4605
SekibOmazic · Feb 8, 2014 · 692b677 · 692b677
1 parent e645f7c
commit 692b677
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/ng/rootScope.js b/src/ng/rootScope.js
@@ -448,7 +448,8 @@ function $RootScopeProvider(){
             }
             // copy the items to oldValue and look for changes.
             for (var i = 0; i < newLength; i++) {
-              if (oldValue[i] !== newValue[i]) {
+              var bothNaN = (oldValue[i] !== oldValue[i]) && (newValue[i] !== newValue[i]);
+              if (!bothNaN && (oldValue[i] !== newValue[i])) {
                 changeDetected++;
                 oldValue[i] = newValue[i];
               }

diff --git a/test/ng/rootScopeSpec.js b/test/ng/rootScopeSpec.js
@@ -579,6 +579,13 @@ describe('Scope', function() {
           log = [];
           $rootScope.$digest();
           expect(log).toEqual([ '[{},[]]' ]);
+
+          log = [];
+          $rootScope.obj[0] = NaN;
+          $rootScope.$digest();
+          expect(isNaN(log.shift())).toBe(true); //jasmine's toBe and toEqual don't work well with NaNs
+          //expect(log).toEqual([ ]);
+
         });
 
         it('should watch array-like objects like arrays', function () {