feat: replace super-linter with custom linter list

[ChiefHolland]

Contributor Comments

This PR removes the super-linter and replaces it with a list of linters in etc/linters.json. Configuration files for each linter were created in etc/ and match the configs contained in the super-linter. Logic was included to allow custom arguments to be passed in for each linter in an environment variable, as well as a regex-based file exclusion list.

Pull Request Checklist

Thank you for submitting a contribution to the goat!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

• Rebase your branch against the latest commit of the target branch
• If you are adding a dependency, please explain how it was chosen
• If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
• If there is an issue associated with your Pull Request, link the issue to the PR.

[JonZeolla]

Quick review; will need one more full run through of the actual business logic but wanted to get you this feedback sooner

[JonZeolla]

Sorry, I need to un-approve just because it introduces breaking changes when I tested it against some projects.

It scans easy_infra in 7 seconds 👍👍, but fails the build due to the shfmt tabs and cfn-lint issues; we need a way to turn these off or loosen the shfmt rules for now.

We may be able to add an .editorconfig file to the goat/etc/ folder and configure it in line with https://github.com/mvdan/sh/blob/master/cmd/shfmt/shfmt.1.scd but I can't get it to work.

I suggest scanning some other projects manually and see what happens

Also, when we skip a linter we need to add a WARNING: to the end that it was skipped (I did this in 5f92079)

[JonZeolla]

I don't know how to get it to find the .editorconfig because they don't seem to have a way to pass an arbitrary location to load it from. It loads from current directory up to the root - see https://editorconfig.org/#file-location

That will also cause an issue for the .github/linters/ config override approach.

Perhaps the easiest approach is just remove shfmt for now and put it on the backlog?

BTW it looks like there was a config for this in super-linter here.

[JonZeolla]

We don't need to change cfn-lint; I made the recommended changes

[JonZeolla]

LGTM! 🚀