Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libslink] precision and naming #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FMassin
Copy link

@FMassin FMassin commented Oct 8, 2021

This would be a modification of the info printed by slinktool:

  1. What slinktool calls latency is called delay in scqc, that's why I propose to change the term latency to delay here.
  2. As a SeisComP server should have relatively good timing precision (ntp is ~millisecond?) I think it would be ok and actually useful to print the previous with 3 digits precision.

Note that (2) is already requested on the original slinktool repo since a long time, but it never made it through. (1) is for self consistency within SeisComP context (it is often confusing at least in my groups). I hope it is Ok to break out from original slinktool implementation, but I don't know if there are rules on 3rd party source code modification...

This would be a modification of the info printed by slinktool:
- What slinktool calls latency is called delay in scqc, that's why I propose to change the term latency to delay here.
- As a SeisComP server should have relatively good timing precision (ntp is ~millisecond?) I think it would be ok and actually useful to print the previous with 3 digit precision.
@cla-bot cla-bot bot added the cla-signed The CLA has been signed by all contributors label Oct 8, 2021
@gempa-jabe
Copy link
Contributor

@andres-h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The CLA has been signed by all contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants