Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Iasp91 P S tables small fix #57

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

salichon
Copy link
Contributor

Make this arrival tables more consistent
Avoid a negative value for the S arrival table

Change P arrival at distance and depth 0 
to 0
Change S arrival at distance and depth 0
to 0
make it more into the format
@cla-bot
Copy link

cla-bot bot commented Mar 10, 2022

We require contributors to sign our Contributor License Agreement, and we don't have @salichon on file. In order for us to review and merge your code, please contact @gempa-jabe to get yourself added.

@salichon
Copy link
Contributor Author

Hi @gempa-jabe
a rapid follow up on velocity table fix.
Happy to sign the cla

cheers
jerome (GNS)

@gempa-jabe
Copy link
Contributor

Hi @salichon, I won't merge that easily. I need to confirm at least with @jsaul and even better, with tests. Those tables were added decades ago and I don't know the origin of those values.

@jsaul
Copy link
Contributor

jsaul commented Mar 10, 2022 via email

@salichon
Copy link
Contributor Author

Kia Ora and thanks @jsaul @gempa-jabe
All good to me,
i understand of course this needs some testing and so :)
I made some quick check on my side although not as thoroughly or as lengthy as it could be.
(without the creation of these tables for instance).
This came out of a question about depth comparison for a shallow hypocenter with 2 methods but same iasp91 velocity model.
I wanted to exclude this negative S wave value question from the discussion I had.
Cheers!

@gempa-jabe gempa-jabe marked this pull request as draft July 13, 2023 09:52
@gempa-jabe gempa-jabe changed the title Iasp91 P S tables small fix WIP: Iasp91 P S tables small fix Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants