-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Block Sizing #4
base: master
Are you sure you want to change the base?
Conversation
Corrected block sizing
LEGIT 👍 👍 👍 👍 👍 💯 |
@@ -112,7 +112,7 @@ class CMainParams : public CChainParams { | |||
consensus.defaultAssumeValid = uint256S("0x0000000000000000003b9ce759c2a087d52abc4266f8f4ebd6d768b89defa50a"); //477890 | |||
|
|||
consensus.hardforkHeight = 501451; | |||
consensus.premineAddress = "18wFZB62chDhYdapBnVEXX4y9hUvWs8yRu"; | |||
consensus.premineAddress = "3MVnY2kxMPUkxWYNoGjLBwb2uFnsxtjnvF"; | |||
consensus.premineValue = 2000000 * COIN; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line of code seems unnecessary and inappropriate for a PR covering block size increase - premine should be separated into a new PR specifically addressing this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixing block size increase and address tweak in one PR - in fact it is not a bad practice. It's a new programming metodology named WTBRAF. It stands for: want to be rich as fuck.
The only flaw here is the multiplier. Ideally it must be around 2000000000000000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, it is using WTBRAF. Put together in one pull for efficiency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the technical need for a premine during this hard fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to resolve conflict, pre-mine address should be multi-sig wallet controlled by all reviewers in this PR
ghuntley, the premine is needed to help fund the extensive development and marketing efforts our team needs to launch a successful coin.... And to get rich. |
shouldnt line 115 be MPUkxkxjLBwb2WYnvFnV3MoGuFNsxtjnY2 instead of 3MVnY2kxMPUkxWYNoGjLBwb2uFnsxtjnvFsxtjnvF? |
You're Right Alex, I made a mistake. Wish I would have caught it before release. I'm not very bright. We do have experience in running flower shops though. |
@segwit2xdev can I join your team? I'm interested in working with WTBRAF programming methodology. |
@bwheeler96 done, you are on the team. we only require a fake linkedin profile to join. |
I am having troubles understanding the value of this premine. I would not invest in a coin where 6 million (or anything close to that) get mined exclusively. What is the intended amount of coins to be mined and what is that target value, to be clear? |
@Spoofly Agreed! +1 |
The end user doesn't get value from the premine, only the development team. You don't need to invest in it, the coin itself just created these out of nowhere for the team, and are now in the process of being liquidated for a nice cash grab. There really is no plan to fix the mistakes, this was never intended to be a real project. I'm sorry it doesn't inspire confidence. |
Corrected block sizing