Feat import export binary and decimal seed #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nosedam . Great job! I just tested your commit and it does what PR states and issue asks. Further, I tested on 3.10 and 3.12 pytest, and both passed. |
|
Thanks for trying it @fedebuyito! I will try to improve the binary numbers export and validation by introducing space separation or different colors, so Its easier to identify which digit you are reading. |
|
Hi guys, I added a color feature to prevent confusions in seed binary export |
|
Hi @nosedam . That seems to be fine!
Pytested, too. All passed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows to export and import the seed phrase in binary and decimal format.
Mentioned here: #68
export_binary.mp4
export_decimal.mp4
import_binary.mp4
import_decimal.mp4
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Thanks everyone for checking the PR. All feedback is appreciated!
Any changes that I need to do just tell me!