Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy APIs & transitional code for project workflow #3267

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Jul 10, 2024

UI is migrated to new paths & doesn't reference these type names.

Copy link

github-actions bot commented Jul 10, 2024

🗞 GraphQL Summary

View schema changes
@@ -872,9 +872,8 @@
   primaryLocationId: ID
 
   """Defaults to High, only available on internship projects"""
   sensitivity: Sensitivity
-  step: ProjectStep
   tags: [String!] = []
   type: ProjectType!
 }
 
@@ -4812,30 +4811,8 @@
   """@order 26"""
   Terminated
 }
 
-"""
-A transition for the project workflow.
-
-This is not a normalized entity.
-A transition represented by its `key` can have different field values
-based on the workflow's state.
-"""
-type ProjectStepTransition {
-  disabled: Boolean!
-  disabledReason: String
-
-  """
-  An local identifier for this transition.
-  It cannot be used to globally identify a transition.
-  It is passed to the transition mutation.
-  """
-  key: ID!
-  label: String!
-  to: ProjectStep!
-  type: TransitionType!
-}
-
 enum ProjectType {
   """@order 2"""
   Internship
 
@@ -4870,12 +4847,34 @@
   notes: SecuredRichTextNullable!
   to: ProjectStep!
 
   """The transition taken, null if workflow was bypassed"""
-  transition: ProjectStepTransition
+  transition: ProjectWorkflowTransition
   who: SecuredActor!
 }
 
+"""
+A transition for the project workflow.
+
+This is not a normalized entity.
+A transition represented by its `key` can have different field values
+based on the workflow's state.
+"""
+type ProjectWorkflowTransition {
+  disabled: Boolean!
+  disabledReason: String
+
+  """
+  An local identifier for this transition.
+  It cannot be used to globally identify a transition.
+  It is passed to the transition mutation.
+  """
+  key: ID!
+  label: String!
+  to: ProjectStep!
+  type: TransitionType!
+}
+
 type Prompt {
   """Whether the requesting user can delete this resource"""
   canDelete: Boolean!
   createdAt: DateTime!
@@ -6399,9 +6398,9 @@
   canEdit: Boolean!
   canRead: Boolean!
 
   """The transitions currently available to execute for this project"""
-  transitions: [ProjectStepTransition!]!
+  transitions: [ProjectWorkflowTransition!]!
   value: ProjectStep
 }
 
 """
@@ -7487,9 +7486,8 @@
   primaryLocationId: ID
 
   """Update only available to internship projects"""
   sensitivity: Sensitivity
-  step: ProjectStep
   tags: [String!]
 }
 
 input UpdateProjectChangeRequest {

🚨 Breaking Changes

  • ProjectStepTransition was removed.
  • CreateProject.step was removed.
  • ProjectWorkflowEvent.transition changed type from ProjectStepTransition to ProjectWorkflowTransition.
  • SecuredProjectStep.transitions changed type from [ProjectStepTransition!]! to [ProjectWorkflowTransition!]!.
  • UpdateProject.step was removed.

@CarsonF CarsonF force-pushed the drop-old-project-step-mutation branch 2 times, most recently from 10478a3 to 662c4cf Compare July 11, 2024 21:56
@CarsonF CarsonF changed the base branch from develop to tests/new-project-workflow-kinda July 11, 2024 21:56
@CarsonF CarsonF force-pushed the drop-old-project-step-mutation branch from 662c4cf to 960c901 Compare July 11, 2024 22:27
Base automatically changed from tests/new-project-workflow-kinda to develop July 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant