Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard - overview v0 #18

Merged
merged 28 commits into from
Nov 25, 2024

Conversation

NaryLozano
Copy link
Collaborator

@NaryLozano NaryLozano commented Nov 14, 2024

Hey Team!
Whats new?

  • overview page
  • sidebar
  • stats banner
  • transactions history

Please leave any feedback and try to break it 💥 :)

closes #10

@NaryLozano NaryLozano requested a review from xamcost November 14, 2024 14:18
@NaryLozano NaryLozano self-assigned this Nov 14, 2024
@NaryLozano
Copy link
Collaborator Author

NaryLozano commented Nov 14, 2024

image

@NaryLozano NaryLozano marked this pull request as ready for review November 20, 2024 15:08
@NaryLozano NaryLozano changed the title First v of overview page Dashboard - overview v0 Nov 20, 2024
Base automatically changed from feat/contracting-page-v0 to main November 20, 2024 19:00
return (
<div className='flex h-full'>
<SidebarDashboard />
{/* <Overview /> */}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this Im still deciding how to navigate this side bar, when I'm done with the contracting page Ill delete this comment :)
when clicking on dashboard from the nav bar I think it should render by default the overview, at the moment when clicking on dashboard it renders only the side bar and once you click on overview it shows this page

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when clicking on dashboard from the nav bar I think it should render by default the overview,

Indeed this is the expected behaviour, it would be best to have it this way.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki, I implemented this in the next Pr in contracting v.0. if you think this is enough only for the overview, let me know so we can merge

@NaryLozano NaryLozano changed the base branch from main to feature/Dashboard November 25, 2024 10:36
@NaryLozano NaryLozano merged commit 4904ec5 into feature/Dashboard Nov 25, 2024
@NaryLozano NaryLozano deleted the feat/dashboard-overview-page-v0 branch November 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the offering dashboard overview page v0 (with no backend)
2 participants