Contracting offering v.0 #17
Conversation
|
|
There was a problem hiding this comment.
Thank you for this work @NaryLozano ! This is pretty neat for a first draft. I've dropped a few comments/suggestions, let me know if you want to discuss them.
NaryLozano
force-pushed
the
feat/contracting-page-v0
branch
from
ccf0d99 to
8ba4361
Compare
There was a problem hiding this comment.
Thank you for your efforts @NaryLozano ! The new offering contracting page is really looking great! I don't have deep structural changes to suggest, only small sugestions here and there. Let me know if any of them need clarification.
| {recommendations.map((offering, index) => { | ||
| return ( | ||
| <Link key={`${offering.title}-${offering.created_at}-${index + 1}`} href='#'> | ||
| <OfferingItem |
There was a problem hiding this comment.
It looks a bit cramped with OfferingItem out of the box, and in case the name of the provider ends up being a little long, it may look ugly. Anyway, since we do not have the backend yet for all this, I would suggest not spending time on this, we can simply remove the dataset entry, and impose a minimum space between the left and right side of the card. What do you think ?
There was a problem hiding this comment.
I created a new component with a few modifications, let me know what you think :)
NaryLozano
changed the title
There was a problem hiding this comment.
Awesome work, thank you @NaryLozano ! This page looks fierce great, let's get back to it once we get the backend sorted out.
Hey this is v0 of contracting offering.
What's new?
- Asset
- Credentials
- Dataset Info
- Price Card
- Recommender
- Terms & conditions modal
Everything is being rendered with mocked data, from the
catalogueyou can click any offering and it will take you to the same mockedcontracting pageplease make suggestions and pinpoint things that might not be on the figma.
closes #9