Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespaces to CSharpScalarResolver #584

Closed
lukzas opened this issue Feb 5, 2020 · 2 comments · Fixed by #587
Closed

Add namespaces to CSharpScalarResolver #584

lukzas opened this issue Feb 5, 2020 · 2 comments · Fixed by #587
Labels
beta-available small-improvement
Milestone
v1.23

Comments

@lukzas
Copy link
Contributor

lukzas commented Feb 5, 2020

I wanted to use LINQ and XML inside <script language="c-sharp"> block, but unfortunately assembly reference was not found.

I've checked the code and indeed only System was referenced in a code template. However, it works after I've added them to both template and ReferencedAssemblies field of CompilerParameters()

Could you add some of the standard namespaces that might be useful or parametrize? Also, I can create PR fo you like.
@Seddryck Seddryck added this to the v1.23 milestone Feb 5, 2020
@Seddryck
Copy link
Owner

Seddryck commented Feb 5, 2020

Feel free to submit a PR!

@lukzas lukzas mentioned this issue Mar 1, 2020
Merged
@Seddryck Seddryck linked a pull request Mar 5, 2020 that will close this issue
Feature/add namespaces to csharp scalar resolver (#584) #587
Merged
@lukzas lukzas mentioned this issue Mar 5, 2020
Open
Seddryck pushed a commit that referenced this issue Mar 17, 2020
Merge pull request #587 from lukzas/feature/Add_namespaces_to_CSharpS…
4c8cfa9 
…calarResolver_(#584)

Feature/add namespaces to csharp scalar resolver (#584)
@Seddryck
Copy link
Owner

Beta available at https://ci.appveyor.com/project/Seddryck/nbi/builds/31536821 (version 1.23.0-beta.18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta-available small-improvement
Projects
None yet
Milestone
v1.23
Development

Successfully merging a pull request may close this issue.

Feature/add namespaces to csharp scalar resolver (#584) lukzas/NBi
2 participants
@Seddryck @lukzas