Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support filter distinct when rows have arrays #439

Closed
Seddryck opened this issue Jan 2, 2019 · 3 comments
Closed

Support filter distinct when rows have arrays #439

Seddryck opened this issue Jan 2, 2019 · 3 comments
Labels
beta-available feature-request genbil
Milestone
v1.20

Comments

@Seddryck
Copy link
Owner

Seddryck commented Jan 2, 2019

When using the filter distinct and the rows have two arrays having the same values the second is not filtered out.
@Seddryck Seddryck added this to the v1.20 milestone Jan 2, 2019
@Seddryck
Copy link
Owner Author

Seddryck commented Jan 2, 2019

Cannot reproduce at that moment

@Seddryck
Copy link
Owner Author

Seddryck commented Jan 3, 2019

It’s not really a bug but a limitation of the .Net Framework with DataRowComparer considering arrays as different as soon as they have more than 1 items. It could also be linked to the fact that arrays are in fact IList.

I could implement a new version of DataRowComparer but it sounds easier to implement an action to flatten an array into a string.

User would have to first flatten the array columns and then filter distinct before re-splitting. More lines of code but could be more re-usable.

@Seddryck Seddryck changed the title Filter distinct doesn’t work correctly with arrays Support filter distinct when rows have arrays Jan 3, 2019
Seddryck pushed a commit that referenced this issue Feb 27, 2019
Merge branch 'feature/filter_distinct_when_rows_have_arrays_(#439)' i…
3ac53b7 
…nto develop

# Conflicts:
#	NBi.Testing/NBi.Testing.csproj
@Seddryck
Copy link
Owner Author

https://ci.appveyor.com/project/Seddryck/nbi/builds/22702250/artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta-available feature-request genbil
Projects
None yet
Milestone
v1.20
Development

No branches or pull requests
1 participant
@Seddryck