This repository has been archived by the owner on Apr 19, 2021. It is now read-only.
add log directory creation to postinst #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package drops several files into /etc/cron.d that output logs to /var/log/nsm. If that directory has not yet been created, all of those cron entries generate errors which are sent via email to root. This change creates the log directory upon package installation rather than relying on a subsequent call to sosetup to create it. This avoids a deluge of system emails from cron if there's a delay between package installation and system configuration. An alternative would be to drop all the cron scripts somewhere other than /etc/cron.d, and copy them over during setup (or out if they're for something that's not configured during sosetup). Also, if the log directory is created during installation, the explicit mkdir(s) in sosetup can eventually be removed, although they don't necessarily cause harm.
|
Thanks, petiepooo! I've created Issue 815 for this: |
dougburks
added a commit
that referenced
this pull request
Oct 29, 2015
add log directory creation to postinst
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package drops several files into /etc/cron.d that output logs to /var/log/nsm. If that directory has not yet been created, all of those cron entries generate errors which are sent via email to root.
This change creates the log directory upon package installation rather than relying on a subsequent call to sosetup to create it. This avoids a deluge of system emails from cron if there's a delay between package installation and system configuration.
An alternative would be to drop all the cron scripts somewhere other than /etc/cron.d, and copy them over during setup (or out if they're for something that's not configured during sosetup).
Also, if the log directory is created during installation, the explicit mkdir(s) in sosetup can eventually be removed, although they don't necessarily cause harm.