Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently working on some changes on maple/horizontal FE changes, and I notice that we're using our fork of humanize duration. But it's lacking the proper plural rules for AR as per language plural rules, I can also confirm that's correct since it's my own language. : ))
upon further investigation, it turns out that this change was done to original repo, check getArabicForm function here.
This pr is cpying the minimal changes for the proper plural form in AR, it's missing some stuff of things (tests) but I went with this quick and dirty way to see if I should but more time in this.
This is currently in my own fork, I'll either keep it or move depending on the maintainer decision.
So let me know,