Refactor preference handling #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
udenr
commented
Nov 23, 2022
udenr
commented
- Move all access to preferences into PrefManager.java
- Move preference keys to separate file preference_keys.xml
- Use getSharedPreferences instead of deprecated getDefaultSharedPreferences
- Fix usage of incorrect string values in pref_notification.xml and pref_workout.xml
- Migrate old translated preference values to new non-translatable values in PrefManager.migratePreferences
- Migrate preference from different files to default preference file in PrefManager.migratePreferences
- Move all access to preferences into PrefManager.java - Move preference keys to separate file preference_keys.xml - Use getSharedPreferences instead of deprecated getDefaultSharedPreferences - Fix usage of incorrect string values in pref_notification.xml and pref_workout.xml - Migrate old translated preference values to new non-translatable values in PrefManager.migratePreferences - Migrate preference from different file to default preference file in PrefManager.migratePreferences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.