Emergency Stop button position in the top bar

[ARU64]

With Octoprint 1.5.2, Python 3.7.3 and Octopi 0.18 the big estop or the small estop appear to low in the top bar.

[ZeekWorld]

Same with Dashboard plugin and UI Customizer

[Sebclem]

Ok i can confirm that a conflict with UI Customizer, I will take a look at this and maybee open an issue on UI Customizer repo

[ZeekWorld]

Thank you.

[LazeMSS]

I think in general normally items to the top menu item is placed inside a single div to contain the element.

But im guessing the real problem is including a modal inside the header. If you want a confirm dialog then it should be placed at the end of the body/html.

A couple of other notes:
https://github.com/Sebclem/OctoPrint-SimpleEmergencyStop/tree/master/octoprint_simpleemergencystop/templates - you have "fontawesome.min.css" in her - this is wrong. its also includede here https://github.com/Sebclem/OctoPrint-SimpleEmergencyStop/tree/master/octoprint_simpleemergencystop/static/css which is the right place

Having inline style is bad practive when you have a css file:
https://github.com/Sebclem/OctoPrint-SimpleEmergencyStop/blob/master/octoprint_simpleemergencystop/templates/simpleemergencystop_navbar.jinja2#L2

[LazeMSS]

But i found something that I can try that might actually be better for both our plugins :)

[Sebclem]

The remaining issue should be fixed with the last release.

Sorry for late fix, i was quite busy lately

[Sebclem]

I'm closing this issue, feel free to re-open this issue or open a new one if you still have compatibility issue with UI Customizer