Update to rc6

[gnujeremie]

Issue description
Update to rc6.

Right now, I can see at least the following issue in index.ts:

@angular/core/index has no exported member 'provide'

[timkraut]

I have the same issue

[timwright35]

I put in a PR with changes to make it run with RC6 (See comment though in #606 )

[born2net]

is this the same error you get ?

Uncaught (in promise) Error: (SystemJS) TypeError: core_1.Provider is not a constructor
        at Object.eval (http://localhost:9089/jspm_packages/npm/[email protected]/core.js:18:5)
        at eval (http://localhost:9089/jspm_packages/npm/[email protected]/core.js:23:4)
        at eval (http://localhost:9089/jspm_packages/npm/[email protected]/core.js:24:3)
    Evaluating http://localhost:9089/jspm_packages/npm/[email protected]/core.js

?

[timwright35]

You get that error if you have the older code, look at the PR for support for RC6, it fixes that. Though it seems to be failing some checks.

[born2net]

I did upgrade to 0.13 but still having same issue :(

[timwright35]

The PR has not been push back into the master yet and thus would not show up in the update.

[born2net]

I see... fyi also tried http://plnkr.co/edit/YX7W20?p=preview and changed to rc.6 and same issue.
tx
Sean

[born2net]

wondering if we have a time table to get it pushed to Master as I am show stopped by this,
tx!!!
Sean

[timwright35]

Yea the issue stems from the provide function in the code. Basically in RC5 provide() still worked though it was being moved to {provide:''}, in RC6 the provide() was removed so it breaks. The PR was changing all the provide()'s to the new format.

[timwright35]

As for when the PR will be able to enter master, I have no clue, from what I can see the code is failing on test checks, from a quick look it looks like the testing code was changed in RC6 and is breaking now. I assume that needs fixed before it can be pushed in.

[born2net]

got it tx!

[born2net]

I will see if I can cherry pick the fix :/

[timwright35]

The code that needs changed is in 3 files I believe only.

[born2net]

be greatly appreciated if you had links to them?

[timwright35]

Look Here

[born2net]

got it tx!!!

[born2net]

please up version and push to npm fix on rc.6

[sebholstein]

@born2net done 😺

[born2net]

tx!!!!

[born2net]

is google maps now a module? as directives: [GOOGLE_MAPS_DIRECTIVES], of course wont work.
new docs?

[born2net]

I tried to import AgmCoreModule, which seems to do the trick but I do get an error of:

Uncaught TypeError: Cannot set property stack of [object Object] which has only a getter
  onHandleError 
  ZoneDelegate.handleError  
  onHandleError 
  ZoneDelegate.handleError  
  Zone.runGuarded   

[born2net]

AgmCoreModule.forRoot()
did the trick... next challenge, setCenter not working :/

[born2net]

I confirmed that in current release can't set the center

this.googleMaps.latitude = 0;
this.googleMaps.longitude = 0;

workaround

this.googleMaps['_mapsWrapper'].setCenter({
            lat: lat,
            lng: lng,
        });

[timwright35]

0.14.0 is in matter now

On Sep 2, 2016 6:00 PM, "JavaScriptNinja" [email protected] wrote:

wondering if we have a time table to get it pushed to Master as I am show
stopped by this,
tx!!!
Sean

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#604 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4BgzQanvYNBVVCs7gDbEZch7weeI7yks5qmH93gaJpZM4JycR7
.

[gnujeremie]

great for rc6, thanks :)

[thousight]

I was using LazyMapsAPILoaderConfig in my bootstrapModule() like this:

import { platformBrowserDynamic } from "@angular/platform-browser-dynamic";
import { enableProdMode } from "@angular/core";
import { LazyMapsAPILoaderConfig } from "angular2-google-maps/core/index";
import { AppModule } from "./app.module";

platformBrowserDynamic().bootstrapModule(AppModule, {provide: (LazyMapsAPILoaderConfig, {useFactory: () => {
    let config = new LazyMapsAPILoaderConfig();
    config.apiKey = "...";
    return config;
  }})});

But then I get this error at "provide":

Argument of type '{ provide: { useFactory: () => LazyMapsAPILoaderConfig; }; }' is not assignable to parameter of type '{ useDebug?: boolean; useJit?: boolean; defaultEncapsulation?: ViewEncapsulation; providers?: any...'

Any thoughts?

[maku]

@thousight you should place this provide section in your modules (AppModule) providers arrray...