Fix for bug in cachedInCheckValue when doing/undoing turnskips #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
ForceSkipTurn(),TrySkipTurn(), andUndoSkipTurn()methods. Currently if you use any of these three methods to change the turn and then on that same turn useIsInCheck(), you will always get back false.I did two full runs of the tests, one where after every board setup or move I added a
ForceSkipTurn()followed by anUndoSkipTurn(), and one where I updated the position setup fens to flip the turn order and then added aForceSkipTurn()immediately after. In both cases all the tests still passed.I did see a comment on the
MakeNullMove()method in theChess.Boardclass about being in check potentially being an issue, but I didn't see any (other) code that seemed like that would be an issue (and also didn't notice any issues with this in the tests).