Change temporary file creation api #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raryFile` which returns a pathString consistent with other Grease file-handling methods
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 84.98% 85.15% +0.16%
==========================================
Files 2039 2051 +12
Lines 13997 14115 +118
==========================================
+ Hits 11895 12019 +124
+ Misses 2102 2096 -6 ☔ View full report in Codecov by Sentry. |
|
@theseion |
theseion
requested changes
Feb 4, 2024
.../Grease-Squeak6-Core.package/GRSqueakPlatform.class/instance/writeFileStreamOn.do.binary..st
Outdated
Show resolved
Hide resolved
.../Grease-Squeak6-Core.package/GRSqueakPlatform.class/instance/writeFileStreamOn.do.binary..st
Outdated
Show resolved
Hide resolved
repository/Grease-Tests-Core.package/GRPlatformTest.class/instance/testNewTemporaryFile.st
Outdated
Show resolved
Hide resolved
repository/Grease-Tests-Core.package/GRPlatformTest.class/instance/testNewTemporaryFileNamed.st
Outdated
Show resolved
Hide resolved
...ory/Grease-GemStone-Core.package/GRGemStonePlatform.class/instance/newTemporaryFileNamed..st
Outdated
Show resolved
Hide resolved
…r Pharo and Squeak
…emporary files on gemstone
theseion
approved these changes
Feb 4, 2024
|
@theseion Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the temporary file creation api on GRPlatform consistent with other file handling methods in Grease: they work with path strings rather than file references.
This makes it easier to port uses of it to other platforms, such as porting zinc request streaming to GemStone.
At the same time, we add some missing file manipulation methods to the Squeak platform...