[ issue #71 ] Fixed Ideal DCG calculation

SeaseLtd · Jan 16, 2019 · b77bf5a · b77bf5a
1 parent b62879f
commit b77bf5a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/rre-core/src/main/java/io/sease/rre/core/domain/metrics/impl/NDCGAtTen.java b/rre-core/src/main/java/io/sease/rre/core/domain/metrics/impl/NDCGAtTen.java
@@ -87,7 +87,11 @@ private BigDecimal idealDcg(final JsonNode relevantDocuments) {
 
         Arrays.fill(gains, 0, howManyVeryVeryRelevantDocs, 3);
         if (howManyVeryVeryRelevantDocs < windowSize) {
-            Arrays.fill(gains, howManyVeryVeryRelevantDocs, howManyVeryVeryRelevantDocs + Math.min((windowSize - howManyVeryVeryRelevantDocs), howManyVeryRelevantDocs), 1);
+            Arrays.fill(gains, howManyVeryVeryRelevantDocs, howManyVeryVeryRelevantDocs + howManyVeryRelevantDocs, 2);
+        }
+
+        if (howManyVeryVeryRelevantDocs + howManyVeryRelevantDocs < windowSize) {
+            Arrays.fill(gains, howManyVeryVeryRelevantDocs + howManyVeryRelevantDocs, gains.length - 1, 1);
         }
 
         BigDecimal result = gains.length > 0 ? new BigDecimal(gains[0]) : BigDecimal.ZERO;