Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types before brackets, not depend on codeigniter type db object, update class Name #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hasnat
Copy link

@hasnat hasnat commented Aug 11, 2017

adding more begin_or/begin_and wont add AND/OR before brackets, hence breaks the query.
these changes now by default it would add AND/OR.
you can specify false to not add forcefully.

@hasnat hasnat changed the title Add types before brackets Add types before brackets & not depend on codeigniter type db object Aug 15, 2017
@hasnat
Copy link
Author

hasnat commented Aug 15, 2017

updated tests, added interface to not depend on codeigniter db object, changed class name to queryBuilder

@hasnat hasnat changed the title Add types before brackets & not depend on codeigniter type db object Add types before brackets, not depend on codeigniter type db object, update class Name Aug 15, 2017
@SeanJA
Copy link
Owner

SeanJA commented Aug 15, 2017

I changed some stuff and broke your pull request, will look at it when I get home and add the fixes in

@hasnat
Copy link
Author

hasnat commented Aug 15, 2017

I briefly checked the changes, I see those changes will make this stop working for php 5.2
can we have a different branch for php 5.2 compatibility then?

@hasnat
Copy link
Author

hasnat commented Aug 15, 2017

also thanks for great work and looking into this pull request.

@SeanJA
Copy link
Owner

SeanJA commented Aug 15, 2017

Sure, it is just the namespacing stuff that makes it not work with php 5.2 right?

@hasnat
Copy link
Author

hasnat commented Aug 15, 2017

yeah, namespaces and composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants