feat: Make PublishVolume compatible with Hosts and Host Groups #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the openAPI generated code to accept the different possible return types of show maps depending on the presence of Hosts and Host Groups vs raw initiators. Corresponding updates to the PublishVolume and LUN selection code.
seagate-chris
approved these changes
Jan 7, 2025
| if lun < 1 { | ||
| lun = vol.LUN | ||
| } else if lun != vol.LUN { | ||
| return -1, fmt.Errorf("found multiple LUNs (%d, %d) for volume %s", lun, vol.LUN, volumeID) |
There was a problem hiding this comment.
Why is this an error? Is this restriction in line with other user interfaces, or just an assumption we want to make to keep the API code simpler?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Host and Host Groups on the system when mapping volumes (addresses "duplicate lun" issue: Seagate/seagate-exos-x-csi#113). Update the openAPI generated code to accept the different possible return types of show maps depending on the presence of hosts and host groups vs raw initiators and make corresponding updates in volume publishing and LUN selection routines.
Changes: