refactor: Restructure the v2 library to match go module import requirements #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requirements Go modules require that the module path end in "v2" for module versions 2.x.x. This commit deletes the old v1 directory and renames the former /v2 directory, moving /v2 into the new mcapi directory. The root module is renamed github.com/Seagate/seagate-exos-x-api-go/v2
feedback: 'mcapi' directory name seems redundant, shortening to 'api'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go modules require that the module path end in "v2" for module versions 2.x.x. This commit deletes the old v1 directory and renames the former /v2 directory, moving /v2 into the new mcapi directory. Following the pattern of the klog/v2 module, the root module is renamed github.com/Seagate/seagate-exos-x-api-go/v2, satisfying the go version requirements.
The former v1 module will still be available as version 1.0.17.
This PR also updates a variety of go imports and in doing so makes PRs #47 and #49 redundant