Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ChooseLUN uses next highest lun before wrapping #19

Merged
merged 2 commits into from
May 31, 2022
Merged

Conversation

jskazinski
Copy link

Change ChooseLUN to pick the next highest available lun before wrapping. This avoids an issue where the lun is reused and the determine multipath code in the iscsi lib get confused because the file system is very busy trying to catch up with all the new devices. This allows the pvc-hell stress test to pass but will need to research an alternate approach such as using WWN.

@jskazinski jskazinski self-assigned this May 27, 2022
api.go Show resolved Hide resolved
@jskazinski jskazinski requested a review from David-T-White May 27, 2022 14:41
Copy link

@David-T-White David-T-White left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Collaborator

@seagate-chris seagate-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if Dave's comment is addressed.

@jskazinski jskazinski merged commit 3d1a38b into main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants