Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/klogs #8

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
95978a1
Fix variable assignment in iscsi library
humblec May 19, 2021
3b8158a
Fix unknown field dereferences which cause the build failures
humblec May 19, 2021
87c9b20
Correct error strings in iscsi library code
humblec May 19, 2021
dd4a7fc
Avoid unwanted type conversion
humblec May 19, 2021
fd47a25
Merge pull request #28 from humblec/build
k8s-ci-robot May 19, 2021
121455e
fix example compilation
plaffitt Nov 5, 2020
fca97c2
properly disconnect volume
plaffitt Nov 18, 2020
efce096
standardize Device usage
plaffitt Oct 29, 2021
8f2b4d0
improve error reporting on command execution
plaffitt Jan 11, 2021
d23b324
refactor and simplify Connector
plaffitt Oct 29, 2021
7b2d8ee
add function to resize multipath map
plaffitt Feb 1, 2021
898cec5
check if device exists before flushing it
plaffitt Feb 16, 2021
df4b0a3
fix tests and example
plaffitt Feb 17, 2021
736e81c
replace manual reassignation with stubs in tests
plaffitt Feb 18, 2021
c1dd946
add tests and remove dead code
plaffitt Feb 19, 2021
d1abc07
refactor lsblk
plaffitt Oct 29, 2021
ae559b8
check multipath consistency on connection/disconnection
plaffitt Oct 29, 2021
203e987
fix typo in logs
plaffitt Jun 8, 2021
fb3c9e1
remove devices even if some are missing
plaffitt Jun 9, 2021
52c573c
fix multipath detection on device lost
plaffitt Jun 9, 2021
aac01d4
add hint about multipathd not running in logs
plaffitt Jun 11, 2021
d192526
add a timeout on iscsciadm commands
plaffitt Sep 29, 2021
75f4b8e
backward-compatibility
plaffitt Oct 14, 2021
b0ce999
use raw format in lsblk in order to support a wider range of versions
plaffitt Oct 26, 2021
5c802c4
Merge pull request #29 from enix/fix/disconnect-volume
k8s-ci-robot Nov 10, 2021
83dec6e
update OWNERS file
humblec Dec 9, 2021
56f04a2
make sure the mountTargetDevice in the connector is non nil
humblec Dec 9, 2021
83b78f5
Merge pull request #36 from humblec/owners
k8s-ci-robot Dec 24, 2021
366f319
Merge pull request #35 from humblec/rel-alpha1
k8s-ci-robot Jan 6, 2022
76df1e7
refactor: Switch to using klog structured logging, multipath discover…
jskazinski Jun 10, 2022
873eab9
do not change the module
jskazinski Jun 10, 2022
486ba82
refactor: Switch to using contextual logging
jskazinski Jun 13, 2022
5b75d28
refactor: Using context for external calls and a logger pointer for i…
jskazinski Jun 15, 2022
9ce70c0
refactor: Additional use of context, unit test adjustments
jskazinski Jul 1, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update OWNERS file
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec committed Dec 20, 2021
commit 83dec6e8d90f3a2825d1d1f7ef187b9cd52d3ca0
12 changes: 10 additions & 2 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md

approvers:
- saad-ali
- humblec
- j-griffith
reviews:
- jsafrane
- msau42
- saad-ali
- xing-yang
reviewers:
- humblec
- j-griffith
- jsafrane
- msau42
- saad-ali
- xing-yang