Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Fixes issue found in "fom-ub" by providing process_fid. #592

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

huanghua78
Copy link

@huanghua78 huanghua78 commented Apr 19, 2021

@huanghua78
Copy link
Author

Hello @yanqingfu, can you please verify this PR?

Please run:

./scripts/m0 run-ub

@yanqingfu
Copy link
Contributor

@huanghua78 how to clone this PR?

@huanghua78
Copy link
Author

The easiest way to get a patch,

https://github.com/Seagate/cortx-motr/pull/592.patch

Apply this patch to the "main" branch, and test it.

@yanqingfu
Copy link
Contributor

[root@ssc-vm-2736 cortx-motr]# ./scripts/m0 run-ub
Invalid command: run-ub
Type `m0 help' for usage.

@huanghua78
Copy link
Author

[root@ssc-vm-2736 cortx-motr]# ./scripts/m0 run-ub
Invalid command: run-ub
Type `m0 help' for usage.

Please update to latest "main" branch

@yanqingfu
Copy link
Contributor

yanqingfu commented Apr 20, 2021

looks good

[root@ssc-vm-2736 cortx-motr]# ./scripts/m0 run-ub
----- run_ub -----
-- round 1 --
  ad-ub[...]
  adieu-ub[.....]
  fol-ub[]
  fom-ub[.......]
  list-ub[..]
  memory-ub[........]
  parity-math-ub[............]
  thread-ub[...]
  time-ub[.]
  timer-ub[....................]
  tlist-ub[..]
  trace-ub[...]
  varr-ub[.]

               bench: [   iter]    min    max    avg   std   sec/op   op/sec block_size time_in_sec    bytes                                                   KiB   BW_KiB     IOPS
set: ad-ub
         write-prime: [      1]   0.27   0.27   0.27  0.00% 2.716e-01/3.681e+00     00   0.27         0000                                                  00     00     00
               write: [    100]   0.53   0.53   0.53  0.00% 5.318e-03/1.881e+02     00   0.53         0000                                                  00     00     00
                read: [    100]   0.04   0.04   0.04  0.00% 4.433e-04/2.256e+03     00   0.04         0000                                                  00     00     00
set: adieu-ub
         write-prime: [      1]   0.00   0.00   0.00  0.00% 1.720e-04/5.814e+03   4096   0.00        16384                                                  16  93567   5847
               write: [    100]   0.01   0.01   0.01  0.00% 8.707e-05/1.149e+04   4096   0.01      1638400                                                1600 183760  11485
                read: [    100]   0.01   0.01   0.01  0.00% 6.036e-05/1.657e+04   4096   0.01      1638400                                                1600 265120  16570
          iovec-sort: [ 100000]   0.04   0.04   0.04  0.00% 3.601e-07/2.777e+06   4096   0.04   1638400000 16                                             00000 44428400 2776775
        iovec-sort-i: [ 100000]  23.41  23.41  23.41  0.00% 2.341e-04/4.272e+03   4096  23.41   1638400000 16                                             00000  68347   4271
set: fol-ub
set: fom-ub
           mem-bytes: [      1]   0.74   0.74   0.74  0.00% 7.386e-01/1.354e+00     00   0.74         0000 16                                             00000  68347   4271
              mem-KB: [      1]   1.66   1.66   1.66  0.00% 1.658e+00/6.032e-01     00   1.66         0000 16                                             00000  68347   4271
              mem-MB: [      1]   1.81   1.81   1.81  0.00% 1.809e+00/5.529e-01     00   1.81         0000 16                                             00000  68347   4271
        shared-mutex: [      1]  11.74  11.74  11.74  0.00% 1.174e+01/8.521e-02     00  11.74         0000 16                                             00000  68347   4271
        mutex-per-lo: [      1]   1.51   1.51   1.51  0.00% 1.513e+00/6.608e-01     00   1.51         0000 16                                             00000  68347   4271
           long-lock: [      1]  99.73  99.73  99.73  0.00% 9.973e+01/1.003e-02     00  99.73         0000 16                                             00000  68347   4271
               block: [      1]  12.12  12.12  12.12  0.00% 1.212e+01/8.253e-02     00  12.12         0000 16                                             00000  68347   4271
set: list-ub
              insert: [ 100000]  22.51  22.51  22.51  0.00% 2.251e-04/4.443e+03     00  22.51         0000 16                                             00000  68347   4271
              delete: [ 100000]  11.25  11.25  11.25  0.00% 1.125e-04/8.892e+03     00  11.25         0000 16                                             00000  68347   4271
set: memory-ub
         alloc-small: [5000000]   0.84   0.84   0.84  0.00% 1.689e-07/5.921e+06     00   0.84         0000 16                                             00000  68347   4271
          free-small: [5000000]   0.40   0.40   0.40  0.00% 8.035e-08/1.245e+07     00   0.40         0000 16                                             00000  68347   4271
        alloc-medium: [5000000]   0.69   0.69   0.69  0.00% 1.383e-07/7.232e+06     00   0.69         0000 16                                             00000  68347   4271
         free-medium: [5000000]   0.41   0.41   0.41  0.00% 8.172e-08/1.224e+07     00   0.41         0000 16                                             00000  68347   4271
         alloc-large: [5000000]   2.35   2.35   2.35  0.00% 4.706e-07/2.125e+06     00   2.35         0000 16                                             00000  68347   4271
          free-large: [5000000]   0.95   0.95   0.95  0.00% 1.900e-07/5.263e+06     00   0.95         0000 16                                             00000  68347   4271
          alloc-huge: [   5000]   0.37   0.37   0.37  0.00% 7.445e-05/1.343e+04     00   0.37         0000 16                                             00000  68347   4271
           free-huge: [   5000]   0.11   0.11   0.11  0.00% 2.246e-05/4.453e+04     00   0.11         0000 16                                             00000  68347   4271
set: parity-math-ub
         s 10/05/ 4K: [    100]   3.85   3.85   3.85  0.00% 3.849e-02/2.598e+01   4096   3.85      6144000                                                6000   1559     25
         m 20/06/ 4K: [    100]  23.09  23.09  23.09  0.00% 2.309e-01/4.331e+00   4096  23.09     10649600  1                                             0400    450     04
         l 30/12/ 4K: [    100]  70.61  70.61  70.61  0.00% 7.061e-01/1.416e+00   4096  70.61     17203200  1                                             6800    237     01
         s 10/05/32K: [    100]  30.87  30.87  30.87  0.00% 3.087e-01/3.240e+00  32768  30.87     49152000  4                                             8000   1555     03
         m 20/06/32K: [    100] 184.67 184.67 184.67  0.00% 1.847e+00/5.415e-01  32768 184.67     85196800  8                                             3200    450     00
         l 30/12/32K: [    100] 565.72 565.72 565.72  0.00% 5.657e+00/1.768e-01  32768 565.72    137625600 13                                             4400    237     00
        s  03/02/ 1M: [    100]  55.35  55.35  55.35  0.00% 5.535e-01/1.807e+00 1048576  55.35    524288000 5                                             12000   9251     01
         m 06/03/ 1M: [    100] 259.63 259.63 259.63  0.00% 2.596e+00/3.852e-01 1048576 259.63    943718400 9                                             21600   3549     00
         l 08/04/ 1M: [    100] 551.46 551.46 551.46  0.00% 5.515e+00/1.813e-01 1048576 551.46   1258291200 1                                             228800   2228     00
          s 04/02/4K: [    100]   0.38   0.38   0.38  0.00% 3.807e-03/2.627e+02   4096   0.38      2457600                                                2400   6304    262
        m 04/02/256K: [    100]  24.26  24.26  24.26  0.00% 2.426e-01/4.123e+00 262144  24.26    157286400 15                                             3600   6332     04
          l 04/02/1M: [    100]  97.18  97.18  97.18  0.00% 9.718e-01/1.029e+00 1048576  97.18    629145600 6                                             14400   6322     01
set: thread-ub
               spawn: [  10000]   0.36   0.36   0.36  0.00% 3.648e-05/2.741e+04     00   0.36         0000 61                                             4400   6322     01
                join: [  10000]  34.95  34.95  34.95  0.00% 3.495e-03/2.861e+02     00  34.95         0000 61                                             4400   6322     01
          spawn-init: [  10000] 186.31 186.31 186.31  0.00% 1.863e-02/5.367e+01     00 186.31         0000 61                                             4400   6322     01
set: time-ub
                 now: [16777216]   0.56   0.56   0.56  0.00% 3.332e-08/3.002e+07     00   0.56         0000 6                                             14400   6322     01
set: timer-ub
        S-<init>-fin: [      1]   0.00   0.00   0.00  0.00% 8.000e-05/1.250e+04     00   0.00         0000 61                                             4400   6322     01
        H-<init>-fin: [      1]   0.00   0.00   0.00  0.00% 3.000e-05/3.333e+04     00   0.00         0000 61                                             4400   6322     01
        S-init-<fini: [      1]   0.03   0.03   0.03  0.00% 3.357e-02/2.979e+01     00   0.03         0000 61                                             4400   6322     01
        H-init-<fini: [      1]   0.00   0.00   0.00  0.00% 2.000e-06/5.000e+05     00   0.00         0000 61                                             4400   6322     01
        S-init-<star: [      1]   0.00   0.00   0.00  0.00% 1.000e-05/1.000e+05     00   0.00         0000 61                                             4400   6322     01
        H-init-<star: [      1]   0.00   0.00   0.00  0.00% 2.000e-06/5.000e+05     00   0.00         0000 61                                             4400   6322     01
        S-init-start: [      1]   0.01   0.01   0.01  0.00% 7.233e-03/1.383e+02     00   0.01         0000 61                                             4400   6322     01
        H-init-start: [      1]   0.00   0.00   0.00  0.00% 1.000e-06/1.000e+06     00   0.00         0000 61                                             4400   6322     01
        S-init-<star: [      1]   0.01   0.01   0.01  0.00% 7.216e-03/1.386e+02     00   0.01         0000 61                                             4400   6322     01
        H-init-<star: [      1]   0.00   0.00   0.00  0.00% 3.000e-06/3.333e+05     00   0.00         0000 61                                             4400   6322     01
        S-<init-star: [      1]   0.01   0.01   0.01  0.00% 7.236e-03/1.382e+02     00   0.01         0000 61                                             4400   6322     01
        H-<init-star: [      1]   0.00   0.00   0.00  0.00% 9.000e-06/1.111e+05     00   0.00         0000 61                                             4400   6322     01
        S-<init-star: [      1]   0.04   0.04   0.04  0.00% 3.557e-02/2.811e+01     00   0.04         0000 61                                             4400   6322     01
        H-<init-star: [      1]   0.00   0.00   0.00  0.00% 1.700e-05/5.882e+04     00   0.00         0000 61                                             4400   6322     01
        S-init-<star: [      1]   0.01   0.01   0.01  0.00% 7.487e-03/1.336e+02     00   0.01         0000 61                                             4400   6322     01
        H-init-<star: [      1]   0.00   0.00   0.00  0.00% 1.400e-05/7.143e+04     00   0.00         0000 61                                             4400   6322     01
        S-init-start: [      1]   0.01   0.01   0.01  0.00% 7.660e-03/1.305e+02     00   0.01         0000 61                                             4400   6322     01
        H-init-start: [      1]   0.00   0.00   0.00  0.00% 1.000e-06/1.000e+06     00   0.00         0000 61                                             4400   6322     01
        S-<init-star: [      1]   0.03   0.03   0.03  0.00% 3.468e-02/2.884e+01     00   0.03         0000 61                                             4400   6322     01
        H-<init-star: [      1]   0.00   0.00   0.00  0.00% 1.600e-05/6.250e+04     00   0.00         0000 61                                             4400   6322     01
set: tlist-ub
              insert: [ 100000]  82.17  82.17  82.17  0.00% 8.217e-04/1.217e+03     00  82.17         0000 61                                             4400   6322     01
              delete: [ 100000]  24.94  24.94  24.94  0.00% 2.494e-04/4.009e+03     00  24.94         0000 61                                             4400   6322     01
set: trace-ub
               empty: [5000000]   0.24   0.24   0.24  0.00% 4.852e-08/2.061e+07     00   0.24         0000 61                                             4400   6322     01
                   8: [5000000]   0.20   0.20   0.20  0.00% 3.934e-08/2.542e+07     00   0.20         0000 61                                             4400   6322     01
                  64: [5000000]   0.22   0.22   0.22  0.00% 4.310e-08/2.320e+07     00   0.22         0000 61                                             4400   6322     01
set: varr-ub
                varr: [      1] 820.23 820.23 820.23  0.00% 8.202e+02/1.219e-03     00 820.23         0000 61                                             4400   6322     01
You have new mail in /var/spool/mail/root
[root@ssc-vm-2736 cortx-motr]#

@huanghua78 huanghua78 requested a review from sanjognaik April 20, 2021 07:47
@stale
Copy link

stale bot commented Apr 24, 2021

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @huanghua78 @mukundkanekar for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@stale stale bot removed the needs-attention label Apr 27, 2021
@huanghua78 huanghua78 merged commit 2d26847 into Seagate:main Apr 27, 2021
@cortx-admin
Copy link

Jenkins CI Result : Motr#391

Motr Test Summary

Test ResultCountInfo
❌Failed0
📁

🏁Skipped5
📁

01motr-single-node/37protocol
04motr-single-node/31motr-sys-kvs-kernel-test
05motr-single-node/07multi-client-tests
05motr-single-node/39mount-fail
05motr-single-node/12sns-cc-io-tests

✔️Passed59
📁

01motr-single-node/46m0crate
01motr-single-node/01kernel-tests
01motr-single-node/00userspace-tests
01motr-single-node/03initscript-tests
01motr-single-node/30hagen-test
01motr-single-node/29confgen-test
01motr-single-node/35m0singlenode
01motr-single-node/04net-tests
01motr-single-node/05rpcping-tests
01motr-single-node/28motr-sys-kvs-test
01motr-single-node/06console-tests
01motr-single-node/52singlenode-sanity
02motr-single-node/20pool-version-test
02motr-single-node/21spiel-test
02motr-single-node/47motr-tests-user-kernel
02motr-single-node/09poolmach-tests
02motr-single-node/41motr-conf-update
02motr-single-node/08degraded-mode-tests
02motr-single-node/24m0d-fsync-test
02motr-single-node/02system-tests
02motr-single-node/22rpc-cancel-test
02motr-single-node/53clusterusage-alert
02motr-single-node/23m0d-signal-test
02motr-single-node/51kem
03motr-single-node/54sns-repair-motr-1f
03motr-single-node/59sns-repair-motr-abort
03motr-single-node/17sss-st-test
03motr-single-node/58sns-repair-motr-ios-fail
03motr-single-node/60sns-repair-motr-abort-quiesce
03motr-single-node/55sns-repair-motr-1n-1f
03motr-single-node/56sns-repair-motr-mf
03motr-single-node/61spiel-multi-confd
03motr-single-node/16conf-st-test
03motr-single-node/57sns-repair-motr-1k-1f
03motr-single-node/36spare-reservation
04motr-single-node/51motr-rmw
04motr-single-node/50motr-rm-lock-cc-io
04motr-single-node/25spiel-sns-repair-test
04motr-single-node/33motr-st
04motr-single-node/19sns-abort-test
04motr-single-node/32m0t1fs-rconfc-fail-test
04motr-single-node/34sns-repair-1n-1f
04motr-single-node/26spiel-sns-repair-quiesce-test
04motr-single-node/49motr-rpc-cancel
04motr-single-node/27sns-repair-io-fail-test
04motr-single-node/48motr-raid0-io
05motr-single-node/40motr-dgmode
05motr-single-node/42motr-utils
05motr-single-node/13sns-repair-quiesce
05motr-single-node/45motr-sns-repair-N-1
05motr-single-node/11sns-multi-tests
05motr-single-node/44motr-sns-repair
05motr-single-node/14m0t1fs-fsync-test
05motr-single-node/43motr-sync-replication
05motr-single-node/38sns-abort-quiesce-test
05motr-single-node/15m0t1fs-fwait-test
05motr-single-node/18m0mount-test
05motr-single-node/10sns-single-tests
motr-single-node/62dix-repair-st-lookup-insert

Total64🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

@huanghua78 huanghua78 deleted the ub_fix branch May 20, 2021 05:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants