-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation without gui #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker,
foodprocessor,
ahuynh1289 and
brayan-trejo
as code owners
July 30, 2024 19:08
Dabnsky
approved these changes
Jul 31, 2024
Ferelith-maker
approved these changes
Jul 31, 2024
foodprocessor
requested changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Since we're adding an installer without the GUI, it makes sense that it's called "no GUI", but from the outside looking in, maybe we should use affirmative naming (a term I just invented), meaning that maybe the GUI version is the one that should have a different name (e.g. cloudfuse_gui).
- Since we're adding an installation option, with a couple implications (the startup automation is being removed too), I think this PR needs to include an update to the installation documentation, and maybe the CLI documentation in the README.
- Have you tested this new release process in GitHub Actions?
This reverts commit 6acbc49.
|
foodprocessor
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
Adds options to build Cloudfuse without a gui installation and without the windows startup tool. Allows for a silent installation from the command line without requiring user to interact with the GUI installer when installing on Windows. Adds a new cloudfuse command to add cloudfuse to the WinFSP registry.
Checklist
Related Issues