Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation without gui #297

Merged
merged 14 commits into from
Aug 6, 2024
Merged

Conversation

jfantinhardesty
Copy link
Contributor

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

Adds options to build Cloudfuse without a gui installation and without the windows startup tool. Allows for a silent installation from the command line without requiring user to interact with the GUI installer when installing on Windows. Adds a new cloudfuse command to add cloudfuse to the WinFSP registry.

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

Copy link
Contributor

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Since we're adding an installer without the GUI, it makes sense that it's called "no GUI", but from the outside looking in, maybe we should use affirmative naming (a term I just invented), meaning that maybe the GUI version is the one that should have a different name (e.g. cloudfuse_gui).
  2. Since we're adding an installation option, with a couple implications (the startup automation is being removed too), I think this PR needs to include an update to the installation documentation, and maybe the CLI documentation in the README.
  3. Have you tested this new release process in GitHub Actions?

component/libfuse/libfuse2_handler.go Outdated Show resolved Hide resolved
.goreleaser.yaml Show resolved Hide resolved
@jfantinhardesty
Copy link
Contributor Author

  1. Since we're adding an installer without the GUI, it makes sense that it's called "no GUI", but from the outside looking in, maybe we should use affirmative naming (a term I just invented), meaning that maybe the GUI version is the one that should have a different name (e.g. cloudfuse_gui).
  2. Since we're adding an installation option, with a couple implications (the startup automation is being removed too), I think this PR needs to include an update to the installation documentation, and maybe the CLI documentation in the README.
  3. Have you tested this new release process in GitHub Actions?
  1. I just made that change then reverted it as I am not sure. Since we are removing features (the gui, the startup tool) it seems that it should be indicated by a new name. If someone was upgrading and just picked the cloudfuse option, they would now lose the gui and startup tool.
  2. I added new documentation in the README.
  3. I did test this as a snapshot locally, and then I tested in GitHub actions all the way until actually publishing a release. There could be a slight issue, but I did not want to actually create a release on GitHub.

Copy link
Contributor

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfantinhardesty jfantinhardesty merged commit c887d84 into main Aug 6, 2024
17 checks passed
@jfantinhardesty jfantinhardesty deleted the Add-installation-without-gui branch August 6, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants