-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related queries enhancement #84
Conversation
fd9b9ae
to
63de846
Compare
@@ -1,3 +1,4 @@ | |||
#![recursion_limit = "1024"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder where is the recursion? And why increasing the limit convince Rust compiler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information about the recursion can be found here async-graphql/async-graphql#1125.
An idea is to generate a GraphQL connection node using derives
Hey @karatakis, could you help me resolve the merge conflict? Thanks!! |
9ed74fa
to
27493e9
Compare
Hey @karatakis, I want to double check, is this ready for review? |
27493e9
to
6876726
Compare
@billy1624 its ready |
Wow, that's really sophisticated querying! |
* Add more functions to common libraries * Enforce stricter traits
I have to add some test cases and fix the self ref tests because now it returns a graphql connection node |
041083f
to
440d7c5
Compare
Cool! @billy1624 can review again? |
Okay, may be one dump question. Is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @karatakis, great work!! I got some refactoring. Please check
* Make RelationKeyStruct into struct with named fields * Add RelationParams * Fix clippy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @karatakis, feel free to merge! Nice work!
Typo! Its an old habit from too many RPGs in the past. |
🎉 Released In 0.3.0 🎉Thank you everyone for the contribution! |
PR Info
Make related queries to receive filtering, ordering and (memory) pagination
Example: Get all customers with their address and order (order amount grater than 8 sorted by amount descending, 1st item only)
Move root_query basic dependencies into seaography crate #82Move RelationKey struct to lib #85Adds