Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export internal dependency instead of leaking it into user package #68

Merged
merged 3 commits into from
Oct 8, 2022
Merged

Re-export internal dependency instead of leaking it into user package #68

merged 3 commits into from
Oct 8, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Oct 3, 2022 •
edited by karatakis
Loading

PR Info

Adds

  • seaography re-export heck and itertools. We cannot re-export those dependencies on seaography-macros because proc_macros crate can only export proc_macros.
  • Write seaography version dynamically based on the version of seaography-generator

Changes

  • seaography-generator: Cargo.toml template will not include heck and itertools as dependencies.
  • CI compile generated examples that depends on local seaography

@billy1624 billy1624 requested review from tyt2y3 and karatakis October 3, 2022 10:20
@billy1624 billy1624 self-assigned this Oct 3, 2022
@karatakis karatakis mentioned this pull request Oct 4, 2022
Merged
2 tasks
@billy1624 billy1624 marked this pull request as ready for review October 7, 2022 13:50
@billy1624
Copy link
Member Author

Ready for review

@karatakis
Copy link
Collaborator

Looks good to me

@karatakis karatakis merged commit 57da29c into main Oct 8, 2022
@karatakis karatakis deleted the re-export-internal-dep branch October 19, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karatakis karatakis karatakis approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
2 participants
@billy1624 @karatakis