Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project quality improvements #40

Merged
merged 9 commits into from
Sep 9, 2022
Merged

Project quality improvements #40

merged 9 commits into from
Sep 9, 2022

Conversation

@tyt2y3
Copy link
Member

tyt2y3 commented Sep 4, 2022

Cool. Apart from fixing the CI, this should be good to merge?

* Read configuration from dotenv / environment
* Add expanded CLI param
* Add complexity limit CLI param
* Add depth limit CLI param
itertools = { version = "0.10.3" }
poem = { version = "1.3.29" }
sea-orm = { version = "0.7.0", features = ["<seaography-sql-library>", "runtime-async-std-native-tls"] }
seaography = { path = "../../" } # TODO before production place version here
Copy link
Member

@billy1624 billy1624 Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @karatakis, one nitpick :D

I'd like this to be seaography = { verion = "<seaography-package-version" }. Where <seaography-package-version> is replaced in runtime just like:

Because I hit this error when using the seaography codegen.
This error stem from the assumption that seaography crate is located two parent folder above where the generated project located.

(base)
seaography on  fixes [⇡!?] is 📦 v0.1.0 via 𝗥 v1.63.0 via 🅒 base
➜ pwd
/Applications/MAMP/htdocs/seaography

(base)
seaography on  fixes [⇡!?] is 📦 v0.1.0 via 𝗥 v1.63.0 via 🅒 base
➜ cargo r mysql://root:root@localhost/sakila mysql mysql
    Finished dev [unoptimized + debuginfo] target(s) in 1.10s
     Running `target/debug/seaography 'mysql://root:root@localhost/sakila' mysql mysql`
`cargo metadata` exited with an error: error: failed to load manifest for dependency `seaography`

Caused by:
  failed to read `/Applications/MAMP/htdocs/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
cargo-fmt
This utility formats all bin and lib files of the current crate using rustfmt.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Although I think we have to publish the crates for this to work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooner or later loll

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can look it up when we publish the project. thanks for the report

@karatakis karatakis changed the title [WIP] Various fixes Project quality improvements Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants