Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of Postgres user-defined types #84

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Fix parsing of Postgres user-defined types #84

merged 1 commit into from
Oct 26, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Oct 25, 2022 •
edited
Loading

PR Info

Fixes

  • An edge case where data_type column equals to USER-DEFINED is being overlooked, this makes Enum column will be treated as Type::Unknown

@billy1624 billy1624 self-assigned this Oct 25, 2022
@tyt2y3
Copy link
Member

tyt2y3 commented Oct 25, 2022

Does this break all Postgres enums?

@billy1624
Copy link
Member Author

Does this break all Postgres enums?

Yes, it does!

@billy1624 billy1624 marked this pull request as ready for review October 26, 2022 03:03
@billy1624 billy1624 mentioned this pull request Oct 26, 2022
Merged
1 task
@billy1624 billy1624 merged commit b4a6836 into master Oct 26, 2022
@billy1624 billy1624 deleted the fix-parsing-user-define-type branch October 26, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billy1624 @tyt2y3