Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse & write Postgres array datatypes #83

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Parse & write Postgres array datatypes #83

merged 4 commits into from
Oct 21, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Oct 20, 2022 •
edited
Loading

PR Info

Adds

  • Parsing and writing Postgres array datatypes

Breaking Changes

  • Changing postgres::def::Type::Array to postgres::def::Type::Array(SeaRc<Type>)

@billy1624 billy1624 self-assigned this Oct 20, 2022
@billy1624 billy1624 marked this pull request as ready for review October 20, 2022 11:11
@billy1624 billy1624 requested a review from tyt2y3 October 20, 2022 11:12
@billy1624
Copy link
Member Author

Ready for review @tyt2y3

tyt2y3
tyt2y3 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

@tyt2y3 tyt2y3 merged commit 9c91fd4 into master Oct 21, 2022
@tyt2y3 tyt2y3 deleted the parse-and-write-pg-array-types branch October 21, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billy1624 @tyt2y3