Support Postgres jsonb in entity generation #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @silverlyra, thanks for contributing! Sorry for the delay. I just added the parsing part and committed to... Could you please review it and cherry-pick it to this PR? Thanks! |
silverlyra
force-pushed
the
postgres-jsonb-writer
branch
from
b57209f to
455953a
Compare
|
@billy1624 ah thanks! updated this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
sea-orm-cli generate entitycurrently treats Postgresjsonbcolumns as an unknown custom datatype, and gives its model field typeString. It already supportsjsoncolumns, and sea-query already supportsjson_binaryinColumnDef, so this just fills in the missing pieces to recognizejsonb.Breaking Changes
No breaking changes.
Changes
No other changes.