-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write MySQL & Postgres Enum Columns #29
Conversation
I don't actually understand why this is necessary. But certainly does not seem right. |
It's needed because the "schema prefix" will be and should be ignored by MySQL & SQLite
I will go with
How is that sounds? @tyt2y3 |
Hey @tyt2y3, |
Cargo.toml
Outdated
@@ -32,7 +32,7 @@ path = "src/lib.rs" | |||
[dependencies] | |||
futures = { version = "0.3", optional = true } | |||
sea-schema-derive = { version = "0.1.0", path = "sea-schema-derive" } | |||
sea-query = { version = "^0.18.1" } | |||
sea-query = { version = "^0.19.0", git = "https://github.com/SeaQL/sea-query.git", branch = "table-ref-db-prefix" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to wait for the next 'train' of sea-query release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we can merge this into master first without release a new version of sea-schema now
@@ -32,7 +32,7 @@ path = "src/lib.rs" | |||
[dependencies] | |||
futures = { version = "0.3", optional = true } | |||
sea-schema-derive = { version = "0.1.0", path = "sea-schema-derive" } | |||
sea-query = { version = "^0.18.1" } | |||
sea-query = { version = "^0.19.0", git = "https://github.com/SeaQL/sea-query.git", branch = "pulls/201" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please release sea-query and remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please release sea-schema as well
PR Info
TableRef::DatabaseSchemaTable
sea-query#193TableRef
for all databases sea-query#202