Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover unique indexes #133

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Discover unique indexes #133

merged 5 commits into from
Jun 19, 2024

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Jun 7, 2024

PR Info

Bug Fixes

  • Discover MySQL, SQLite and PostgreSQL unique indexes

@billy1624 billy1624 requested a review from tyt2y3 June 7, 2024 09:22
@billy1624 billy1624 self-assigned this Jun 7, 2024
@billy1624 billy1624 marked this pull request as ready for review June 7, 2024 09:41
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, mystery solved

@@ -5,3 +5,16 @@ pub struct Schema {
pub tables: Vec<TableDef>,
pub indexes: Vec<IndexInfo>,
}

impl Schema {
pub fn collect_unique_indexes(mut self) -> Self {
Copy link
Member

@tyt2y3 tyt2y3 Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge_indexes_into_table?

@billy1624 billy1624 merged commit 29d9804 into master Jun 19, 2024
5 of 16 checks passed
@billy1624 billy1624 deleted the discover-unique-indexes branch June 19, 2024 10:47
Copy link

github-actions bot commented Aug 9, 2024

🎉 Released In 0.15.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants