Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgvector type #774

Merged
merged 15 commits into from
Aug 9, 2024
Merged

Add pgvector type #774

merged 15 commits into from
Aug 9, 2024

Conversation

28Smiles
Copy link
Contributor

@28Smiles 28Smiles commented Apr 21, 2024

Once this gets merged i'll clean the implementations of the feature in sea-orm and sea-schema. I tested the feature with my forks.

New Features

  • Add support for the postgres vector extension

Breaking Changes

Exhaustive columtype matching will break

Changes

  • Add new value variant named Vector and Column Type

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 23, 2024

Thank you for your contribution. You have many commits!

@28Smiles
Copy link
Contributor Author

@tyt2y3 Should i consolidate them or do you squash them on merge?

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 24, 2024

NO problem, I'll take some time to review it

@28Smiles
Copy link
Contributor Author

28Smiles commented Aug 5, 2024

@tyt2y3 Since i really want to stop using my own forks for this feature, it would be nice to get some progress here. Is there anything i am able to do?

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 5, 2024

sorry for the delay. can you rebase this branch onto latest master?

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 5, 2024

it looks pretty safe, everything is behind a feature guard 👍

@28Smiles
Copy link
Contributor Author

28Smiles commented Aug 5, 2024

@tyt2y3 needed to fix the version should be done now

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience. will merge and release soon

@billy1624 billy1624 merged commit b83eaa9 into SeaQL:master Aug 9, 2024
29 checks passed
Copy link

github-actions bot commented Aug 9, 2024

🎉 Released In 0.32.0-rc.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Copy link

🎉 Released In 0.32.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@dattito
Copy link

dattito commented Nov 26, 2024

any progress for the feature in sea-orm? Would be very happy to use it in there, but unfortunately I don't have enough experience myself to implement it

@28Smiles
Copy link
Contributor Author

any progress for the feature in sea-orm? Would be very happy to use it in there, but unfortunately I don't have enough experience myself to implement it

I have a pull request for the next layer sea-schema if that is merged we can merge into sea-orm. You may just use my fork until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants