Fix incorrect behavior when adding an autoincrement column to a Postg… #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Bug Fixes
Using the
PostgresQueryBuilder
I would've expected this:to give me: (This behavior is true if you use
Table::create
)ALTER TABLE "test" ADD COLUMN "id" serial PRIMARY KEY
Instead it gave me:
ALTER TABLE "test" ADD COLUMN "id" integer PRIMARY KEY
Breaking Changes
If someone was using
auto_increment()
on anything but aninteger
,smallinteger
, orbiginteger
it would cause a panic.Changes
Modified the postgres
alter_10
test to test against the correct behavior.