Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Table::truncate() panic for Sqlite backend #590

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Make Table::truncate() panic for Sqlite backend #590

merged 2 commits into from
Feb 1, 2023

Conversation

elbertronnie
Copy link
Contributor

PR Info

Bug Fixes

  • It allowed the construction of TRUNCATE statement even though it is not supported by Sqlite.

Breaking Changes

  • Using Table::truncate() with Sqlite backend will now panic.

billy1624
billy1624 reviewed Jan 30, 2023
View reviewed changes
tests/sqlite/table.rs Outdated Show resolved Hide resolved
billy1624
billy1624 reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @elbertronnie, thanks for contributing!!

I saw you're fixing clippy warnings in this PR thanks for that! I'm going to fix it in #592 and merge it into master. So maybe you can rebase this onto master later, once it has been merged into master.

ikrivosheev
ikrivosheev approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elbertronnie hello! Thank you for PR! LGTM!

@ikrivosheev ikrivosheev merged commit 37eb7d8 into SeaQL:master Feb 1, 2023
@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev approved these changes

@tyt2y3 tyt2y3 tyt2y3 approved these changes

@billy1624 billy1624 Awaiting requested review from billy1624

Assignees

@elbertronnie elbertronnie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TRUNCATE equivalent in SQLite
4 participants
@elbertronnie @tyt2y3 @ikrivosheev @billy1624